Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.flask-security-too: init at 4.1.2 #155212

Merged
merged 1 commit into from
Jan 18, 2022
Merged

python3Packages.flask-security-too: init at 4.1.2 #155212

merged 1 commit into from
Jan 18, 2022

Conversation

gador
Copy link
Member

@gador gador commented Jan 16, 2022

Init of Flask-security-too

Motivation for this change

needed for pgadmin4 init
#154764

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    NOTE: Due to a pony requirement (python 3.3-3.9), this package fails to build in Python3.10
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@gador gador requested review from FRidh and jonringer as code owners January 16, 2022 13:15
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 16, 2022
@ofborg ofborg bot requested a review from mkg20001 January 16, 2022 13:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 16, 2022
@fabaff
Copy link
Member

fabaff commented Jan 16, 2022

The pony failure should be addressed with #155230.

SuperSandro2000
SuperSandro2000 requested changes Jan 16, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the init commit.

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/flask-security-too/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/flask-security-too/default.nix Outdated Show resolved Hide resolved
This was referenced Jan 17, 2022
Merged
Merged
Merged
@gador
Copy link
Member Author

gador commented Jan 17, 2022

Fails due to missing maintainer info #155411

@gador
Copy link
Member Author

gador commented Jan 18, 2022

@ofborg eval

@gador
Copy link
Member Author

gador commented Jan 18, 2022

@mkg20001 I removed you as maintainer in the last commit, since I haven't heard from you since #154764 (review)
If you still want to be listed as maintainer, please let me know

@SuperSandro2000 SuperSandro2000 changed the title python3Packages.flask-security-too: init python3Packages.flask-security-too: init at 4.1.2 Jan 18, 2022
@gador
Copy link
Member Author

gador commented Jan 18, 2022

@ofborg eval

@mkg20001
Copy link
Member

@gador I think I'm already maintaining too many packages 😅 I'll leave them to you

@gador
Copy link
Member Author

gador commented Jan 18, 2022

@mkg20001 ok 😀

@gador gador force-pushed the flask-security-too-init branch from edef21d to 5a82b24 Compare January 18, 2022 20:30
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 155212 run on x86_64-linux 1

2 packages built:
  • python310Packages.flask-security-too
  • python39Packages.flask-security-too

@SuperSandro2000 SuperSandro2000 merged commit 6733a4d into NixOS:master Jan 18, 2022
@gador gador deleted the flask-security-too-init branch January 19, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gador @fabaff @mkg20001 @SuperSandro2000