Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pine64-pinebook-pro: improvements and simplifications #743

Merged
merged 5 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 5 additions & 25 deletions pine64/pinebook-pro/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -36,38 +36,18 @@
"tcpm"
"typec"

# PCIe/NVMe
"nvme"
"pcie_rockchip_host"
"phy_rockchip_pcie"

# Misc. modules
"cw2015_battery"
"gpio_charger"
"rtc_rk808"
];

services.udev.extraHwdb = lib.mkMerge [
# https://github.com/elementary/os/blob/05a5a931806d4ed8bc90396e9e91b5ac6155d4d4/build-pinebookpro.sh#L253-L257
# Disable the "keyboard mouse" in libinput. This is reported by the keyboard firmware
# and is probably a placeholder for a TrackPoint style mouse that doesn't exist
''
evdev:input:b0003v258Ap001Ee0110-e0,1,2,4,k110,111,112,r0,1,am4,lsfw
ID_INPUT=0
ID_INPUT_MOUSE=0
''
];

# https://github.com/elementary/os/blob/05a5a931806d4ed8bc90396e9e91b5ac6155d4d4/build-pinebookpro.sh#L253-L257
# Mark the keyboard as internal, so that "disable when typing" works for the touchpad
environment.etc."libinput/local-overrides.quirks".text = ''
[Pinebook Pro Keyboard]
MatchUdevType=keyboard
MatchBus=usb
MatchVendor=0x258A
MatchProduct=0x001E
AttrKeyboardIntegration=internal
'';

hardware.enableRedistributableFirmware = true;
hardware.firmware = [
(pkgs.callPackage ./firmware/ap6256-firmware { })
];

# The default powersave makes the wireless connection unusable.
networking.networkmanager.wifi.powersave = lib.mkDefault false;
Expand Down
39 changes: 0 additions & 39 deletions pine64/pinebook-pro/firmware/ap6256-firmware/default.nix

This file was deleted.