pine64-pinebook-pro: improvements and simplifications #743
Conversation
tomfitzhenry
changed the title
|
Looks plausibly okay from just reading the diff. (I haven't been using mine for much other than Tow-Boot dev...) So tentatively half-approved, because it sure looks like it's fine. |
pine64/pinebook-pro/default.nix
Outdated
| @@ -8,6 +8,10 @@ | |||
|
|
|||
| boot.kernelPackages = lib.mkDefault pkgs.linuxPackages_latest; | |||
|
|
|||
| boot.kernelParams = [ | |||
| "console=tty0" | |||
There was a problem hiding this comment.
@samueldr what is your opinion on this?
Related: #745 (comment)
There was a problem hiding this comment.
I guess by default it will try some serial device instead, which is not so nice for a laptop?
There was a problem hiding this comment.
I will move this PR into draft state until I understand the subtleties of setting console=.
There was a problem hiding this comment.
I have some understanding of the option in case you have questions.
There was a problem hiding this comment.
https://github.com/torvalds/linux/blob/master/Documentation/admin-guide/serial-console.rst was instructive to me, and systemd/systemd#9899 re systemd's relationship to console=.
I think it's better if console= is not set, on the basis that:
- users might not want the bootlog on their display
- the right-most console= directive is semantically important (its used as
/dev/console), and so overriding becomes trickier.
How does that sound? I have removed that commit from the PR.
There was a problem hiding this comment.
I think I misspoke in the previous comment in what I think the best option is for this.
A default might be right, and it would depend on the device type.
We can't rely on the "unconfigured default", since in DT-land Linux defaults it relies on /chosen/stdout-path, which sometimes doesn't make sense given a target:
But setting console= without qualifying it is kinda rude as it prevents the user from "simply" choosing another one.
So the workaround (with our semantics) is to put it at the leftmost location. In other words:
boot.kernelParams = mkBefore [ "console=tty0" ];
This would be for devices we can ascertain that most users would expect a given default console choice.
This quirk has been upstreamed, and thus we longer need to keep it in nixos-hardware: https://gitlab.freedesktop.org/libinput/libinput/-/commit/c053d7b078b7ebc067c24fd43c728ec0dcd69bfd
It's not clear what this is for, and other distros ( https://gitlab.com/postmarketOS/pmaports/-/commit/e9029c91536edbe3fd4109b90cfa92eddfd890b0 ) are now relying solely on upstream udev.
tomfitzhenry
force-pushed
the
pinebook-pro
branch
from
9708313 to
837cda5
Compare
I have been running for >1 year with the upstream linux-firmware package (i.e. just hardware.enableRedistributableFirmware = true) https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/WHENCE#n2767
tomfitzhenry
force-pushed
the
pinebook-pro
branch
from
837cda5 to
8518dc8
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d6b554a |
Description of changes
Improvements to the Pine64 Pinebook Pro config:
See commit messages for more details.
I have been running this config for >6 months.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input