Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down the main snowflake SVG #38

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Oct 7, 2018

No version goes step by step, and keeps the layers, structure, and most numbers.

@samueldr
Copy link
Member

samueldr commented Oct 8, 2018

Hi!

Still a bit unsure about some of the changes (see comment on #39), but let's focus on logo/nix-snowflake.svg, everything else we'll see after.


nix-snowflake.svg

The changes to #layer2 (print-logo) and #layer3 (gradient-logo) are almost perfect! Only nit is s/gradiant/gradient/g, a simply typo.

Now, about the other layers: I say we ought to delete them outright. (guides, logo-guide and bg). They all start up hidden, and contain now irrelevant things.

image

They are, I would bet, artifacts from the isolated snowflake being made from the logo with text file. The background isn't used, and isn't really relevant (and wrongly sized). The logo-guide isn't respected by the document's size, and the guides layer is outright random scraps initially used to build the lambdas.

What are your thoughts about that? (When I was talking about guides and grids on the other PR, I wasn't talking about discrete SVG elements being used as guides, but the inkscape concept of grids and guides, which this document doesn't use.)


(I'm not trying to push to this branch as it may be harder to resolve conflicts in such complex documents.) With those removed, there wouldn't be much left I guess.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Oct 8, 2018

Heh. Doing this I was almost thinking of going the other extreme with one big inkscape-esque "source" SVG to generate everything so as not to duplicate the snowflake everywhere. Maybe we could do cross file relative URLs in uses for things which would be the best of both worlds, but I'm not sure whether anything let alone inkscape supports that.

In any event, I'm now enamored of the incrementalism of this. I think good to clean up as is to keep options open, even if we chuck some stuff right after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants