Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo: Provide an easy path to optimized SVGs and exported PNGs #123

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

samueldr
Copy link
Member

The non-logo files are not part of the build, as they are files made for specific usage, and should not be part of the NixOS assets for general usage.

With the added Nix expression, someone that needs PNGs or optimized SVGs can get them more easily than previously, where they'd need to get into inkscape and export the files.

With future clean-up work, this may be enhanced by exporting different layers. This would allow exporting the flat (for print) and gradient based variants.

It's done directly as a Nix expression, as these assets are not intended to be part of an automated pipeline. This for end-user convenience.


@Ericson2314 first of all, sorry for the span of years since your initial contribution.

Can you please remind me the rationale behind #37, #38 and #39?

I'm wondering if part of it will be addressed here. I'm thinking mainly about producing "built assets" versions of the SVG files, which drops all inkscape-isms, and then get optimized.

Though I recall (and see) that these also seemed intended to make the files "accessible" to hand editing, though I'm unsure if that was an intention.

Finally, the last thing I understand from what you were doing is you were cleaning up the names and "concepts" in some of the files. Obviously this is not handled here.

(Anyway these changes I think are needed and good, so I'm not blocked by your reply, so take your time. Though I want to understand the needs you had, to handle them.)

The non-logo files are not part of the build, as they are files made for
specific usage, and should not be part of the NixOS assets for general
usage.
@samueldr samueldr added 0. type cleanup 2. topic: official Official branding and artwork labels Apr 12, 2024
@samueldr samueldr merged commit c68a508 into NixOS:master Apr 12, 2024
@samueldr samueldr deleted the feature/build-logos branch April 12, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type cleanup 2. topic: official Official branding and artwork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant