feat(slack): Expose create case slash command #5295
Merged
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the slack conversation plugin, there are slash commands to be used on cases after they are created, but there is no slash command for creating a case. As I looked into this issue, I found that the full setup for allowing the command is present, but the final wire-up of the command was not. I added that final wire-up. I looked for tests for any functionality like this and found none. I can create it, but I have no model to go on.
I am copying work from https://github.com/Netflix/dispatch/pull/5240/files to try and emulate better what I should do. I am pretty stuck on generating an alembic file correctly for this type definition. I'll keep trying to figure it out from the docs, but it's not transparent to me.
bashbreakpoint
force-pushed
the
feat/slack-create-case-slash-command
branch
from
eb15be7 to
e584247
Compare
|
If anyone is looking at this, I'm having trouble creating the alembic file I would need for this type migration. I am following the steps I find in #5240, merged last week. I've never worked with alembic and the contributing docs don't mention how to do this outside the scope of creating a new type. Extending a new type isn't transparent to me, and I'd love to do this the right way. |
metroid-samus
added
feature
enhancement
metroid-samus
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the slack conversation plugin, there are slash commands to be used on cases after they are created, but there is no slash command for creating a case.
As I looked into this issue, I found that the full setup for allowing the command is present, but the final wire-up of the command was not.
I added that final wire-up.
I looked for tests for any functionality like this and found none. I can create it, but I have no model to go on.
I have looked at the Contributing docs on the dispatch web page, but I'm not very sure of the standards here and am fully open to changes and feedback.