Support raise_error() on [databricks] 14.3, Spark 4.
#11969
Merged
+223
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NVIDIA#10969. This commit adds support for `raise_error()` on Databricks 14.3 and Spark 4.0. On these new Spark versions, the `RaiseError` expression (that powers the `raise_error()` API function) was changed from a Unary expression to a Binary one. This was done without modifying the arity of `raise_error()`. The ostensible reason seems to have been to eventually allow user-code to raise custom errors via `raise_error()`. This commit allows `raise_error()` to work on the GPU as it currently does on the CPU: as a unary function powered by a binary expression in the background. The tests have been modified to verify both the new behaviour and the legacy one on new platforms, while continuing to run as before on legacy platforms. Signed-off-by: MithunR <[email protected]>
razajafri
previously approved these changes
Jan 16, 2025
mythrocks
changed the title
raise_error() on Databricks 14.3, Spark 4.raise_error() on [databricks] 14.3, Spark 4.
|
Build |
|
Build |
revans2
reviewed
Jan 16, 2025
sql-plugin/src/main/spark350db143/scala/com/nvidia/spark/rapids/shims/RaiseErrorShim.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark350db143/scala/com/nvidia/spark/rapids/shims/RaiseErrorShim.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/spark350db143/scala/org/apache/spark/sql/rapids/shims/misc.scala
Show resolved
Hide resolved
sql-plugin/src/main/spark350db143/scala/com/nvidia/spark/rapids/shims/RaiseErrorShim.scala
Outdated
Show resolved
Hide resolved
|
Build |
revans2
approved these changes
Jan 17, 2025
|
The errors in license header check are invalid. I will merge this anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10969.
This commit adds support for
raise_error()on Databricks 14.3 and Spark 4.0.On these new Spark versions, the
RaiseErrorexpression (that powers theraise_error()API function) was changed from a Unary expression to a Binary one. This was done without modifying the arity ofraise_error(). The ostensible reason seems to have been to eventually allow user-code to raise custom errors viaraise_error().This commit allows
raise_error()to work on the GPU as it currently does on the CPU: as a unary function powered by a binary expression in the background.The tests have been modified to verify both the new behaviour and the legacy one on new platforms, while continuing to run as before on legacy platforms.