Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] Investigate use of GpuScalar.getValue for MAP scalars in GpuRaiseError #11974

Open
mythrocks opened this issue Jan 17, 2025 · 1 comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working tech debt

Comments

@mythrocks
Copy link
Collaborator

This is a follow-up task for #11969.

GpuRaiseError currently uses GpuScalar.getValue to extract the value of errorParams from the GpuScalar argument in doColumnar(Int, GpuScalar, GpuScalar).

This might well be alright to do. All testing indicates that the Scalar has its host value set correctly.

However, if the host value isn't set, GpuScalar::getValue would use GpuScalar.extract to fetch the value. That method does not handle nested-type scalars correctly.

It would be worth investigating if that's a real possibility, and whether we should handle the map-scalar extraction differently.

@mythrocks mythrocks added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jan 17, 2025
@revans2
Copy link
Collaborator

revans2 commented Jan 17, 2025

Something similar likely shows up in other places too. It would be nice to just fix this for all nested types so we don't have to ever worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working tech debt
Projects
None yet
Development

No branches or pull requests

2 participants