-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update latest changelog [skip ci] #11851
Conversation
Update change log with CLI: \n\n scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12 Signed-off-by: nvauto <[email protected]>
NOTE: Merged Pull Requests w/o Project, please help check if we need update them!
|
All of these pull requests have a project, so not sure what's being requested here. I set the roadmap to 24.12 and assigned a priority, but I don't understand why we would care about the project etc for PRs when generating a changelog. The changelog should be generated by querying Github for what PRs went into the release branch, regardless of what the project says, i.e.: https://github.com/NVIDIA/spark-rapids/pulls?q=is%3Apr+is%3Amerged+base%3Abranch-24.12. Labels can change whether it's grouped in bugfixes, feature, performance improvements, etc, but the list of what's there and what's not should soley be based on pull requests that were merged into the development branch. Depending on metadata that needs to be manually updated is asking for trouble. |
Yes, this suggestion is reasonable! However, there may be other concerns regarding the project roadmap when generating the CHANGELOG. I'll check with @pxLi and follow up on it. |
Confirmed with @pxLi, we are good to generate the CHANGELOG from the target/release branch instead. Previously, the CHANGELOG was managed by labels (the same as the project's roadmap); those PRs without a label are not included in the CHANGELOG. We'll ignore the project roadmap checking and add PRs from the release branch to the CHANGELOG. Follow up on : #11866 |
Signed-off-by: Tim Liu <[email protected]>
Updated the CHANGELOG to latest, @sameerz can you help review it? Thanks! |
I reviewed and made only a minor change in the issue list. Am good if this is regenerated. |
Signed-off-by: Yanxuan Liu <[email protected]>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update rapids JNI and private dependency to 24.12.0 (#11849) \nWait for the pre-merge CI job to SUCCEED Signed-off-by: nvauto <[email protected]> * Update latest changelog [skip ci] (#11851) * Update latest changelog [skip ci] Update change log with CLI: \n\n scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12 Signed-off-by: nvauto <[email protected]> * Update changelog Signed-off-by: Tim Liu <[email protected]> * update changelog to involve new changes. Signed-off-by: Yanxuan Liu <[email protected]> --------- Signed-off-by: nvauto <[email protected]> Signed-off-by: Tim Liu <[email protected]> Signed-off-by: Yanxuan Liu <[email protected]> Co-authored-by: Tim Liu <[email protected]> Co-authored-by: Yanxuan Liu <[email protected]> * Remove 350db143 shim's build (#11874) Skip the build of the 350db143 shim, as v24.12.0 will not contain the 350db143 shim Moreover, the v24.12.0 private dependency jar is not released. To fix below error: [ERROR] Failed to execute goal on project rapids-4-spark-sql_2.12: Could not resolve dependencies for project com.nvidia:rapids-4-spark-sql_2.12:jar:24.12.0: Failure to find com.nvidia:rapids-4-spark-private_2.12:jar:spark350db143:24.12.0 in https://repo1.maven.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced Signed-off-by: Tim Liu <[email protected]> * Update latest changelog [skip ci] (#11876) Update change log with CLI: \n\n scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12 Signed-off-by: nvauto <[email protected]> --------- Signed-off-by: nvauto <[email protected]> Signed-off-by: Tim Liu <[email protected]> Signed-off-by: Yanxuan Liu <[email protected]> Co-authored-by: Jenkins Automation <[email protected]> Co-authored-by: Tim Liu <[email protected]>
Update change log with CLI:
scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12