Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest changelog [skip ci] #11851

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Update latest changelog [skip ci] #11851

merged 3 commits into from
Dec 16, 2024

Conversation

nvauto
Copy link
Collaborator

@nvauto nvauto commented Dec 10, 2024

Update change log with CLI:

scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12

Update change log with CLI: \n\n   scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12

Signed-off-by: nvauto <[email protected]>
@YanxuanLiu YanxuanLiu marked this pull request as draft December 10, 2024 12:09
@YanxuanLiu YanxuanLiu self-assigned this Dec 10, 2024
@YanxuanLiu
Copy link
Collaborator

YanxuanLiu commented Dec 10, 2024

NOTE: Merged Pull Requests w/o Project, please help check if we need update them!

NOTE: Merged Pull Requests w/o Project:
branch-24.12 #11752 Ability to decompress snappy and zstd Parquet files via CPU [databricks] https://github.com/NVIDIA/spark-rapids/pull/11752
branch-24.12 #11759 Avoid using StringBuffer in single-threaded methods. https://github.com/NVIDIA/spark-rapids/pull/11759
branch-24.12 #11766 Fix Kudo batch serializer to only read header in hasNext https://github.com/NVIDIA/spark-rapids/pull/11766
branch-24.12 #11768 Fix `dpp_test.py` failures on [databricks] 14.3 https://github.com/NVIDIA/spark-rapids/pull/11768
branch-24.12 #11771 Fix query hang when using rapids multithread shuffle manager with kudo https://github.com/NVIDIA/spark-rapids/pull/11771
branch-24.12 #11777 Append knoguchi22 to blossom-ci whitelist [skip ci] https://github.com/NVIDIA/spark-rapids/pull/11777
branch-24.12 #11794 exclude previous operator'\''s time out of firstBatchHeuristic https://github.com/NVIDIA/spark-rapids/pull/11794
branch-24.12 #11832 Fix leak in GpuBroadcastNestedLoopJoinExecBase https://github.com/NVIDIA/spark-rapids/pull/11832
branch-24.12 #11845 Fix leak in isTimeStamp https://github.com/NVIDIA/spark-rapids/pull/11845

@YanxuanLiu YanxuanLiu added the build Related to CI / CD or cleanly building label Dec 10, 2024
@jlowe
Copy link
Member

jlowe commented Dec 10, 2024

NOTE: Merged Pull Requests w/o Project, please help check if we need update them!

All of these pull requests have a project, so not sure what's being requested here. I set the roadmap to 24.12 and assigned a priority, but I don't understand why we would care about the project etc for PRs when generating a changelog. The changelog should be generated by querying Github for what PRs went into the release branch, regardless of what the project says, i.e.: https://github.com/NVIDIA/spark-rapids/pulls?q=is%3Apr+is%3Amerged+base%3Abranch-24.12. Labels can change whether it's grouped in bugfixes, feature, performance improvements, etc, but the list of what's there and what's not should soley be based on pull requests that were merged into the development branch. Depending on metadata that needs to be manually updated is asking for trouble.

@NvTimLiu
Copy link
Collaborator

NOTE: Merged Pull Requests w/o Project, please help check if we need update them!

All of these pull requests have a project, so not sure what's being requested here. I set the roadmap to 24.12 and assigned a priority, but I don't understand why we would care about the project etc for PRs when generating a changelog. The changelog should be generated by querying Github for what PRs went into the release branch, regardless of what the project says, i.e.: https://github.com/NVIDIA/spark-rapids/pulls?q=is%3Apr+is%3Amerged+base%3Abranch-24.12. Labels can change whether it's grouped in bugfixes, feature, performance improvements, etc, but the list of what's there and what's not should soley be based on pull requests that were merged into the development branch. Depending on metadata that needs to be manually updated is asking for trouble.

The changelog should be generated by querying Github for what PRs went into the release branch, regardless of what the project says

Yes, this suggestion is reasonable!

However, there may be other concerns regarding the project roadmap when generating the CHANGELOG.

I'll check with @pxLi and follow up on it.

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Dec 12, 2024

NOTE: Merged Pull Requests w/o Project, please help check if we need update them!

All of these pull requests have a project, so not sure what's being requested here. I set the roadmap to 24.12 and assigned a priority, but I don't understand why we would care about the project etc for PRs when generating a changelog. The changelog should be generated by querying Github for what PRs went into the release branch, regardless of what the project says, i.e.: https://github.com/NVIDIA/spark-rapids/pulls?q=is%3Apr+is%3Amerged+base%3Abranch-24.12. Labels can change whether it's grouped in bugfixes, feature, performance improvements, etc, but the list of what's there and what's not should soley be based on pull requests that were merged into the development branch. Depending on metadata that needs to be manually updated is asking for trouble.

The changelog should be generated by querying Github for what PRs went into the release branch, regardless of what the project says

Yes, this suggestion is reasonable!

However, there may be other concerns regarding the project roadmap when generating the CHANGELOG.

I'll check with @pxLi and follow up on it.

Confirmed with @pxLi, we are good to generate the CHANGELOG from the target/release branch instead.

Previously, the CHANGELOG was managed by labels (the same as the project's roadmap); those PRs without a label are not included in the CHANGELOG.

We'll ignore the project roadmap checking and add PRs from the release branch to the CHANGELOG.

Follow up on : #11866

Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu
Copy link
Collaborator

Updated the CHANGELOG to latest, @sameerz can you help review it? Thanks!

@sameerz
Copy link
Collaborator

sameerz commented Dec 13, 2024

Updated the CHANGELOG to latest, @sameerz can you help review it? Thanks!

I reviewed and made only a minor change in the issue list. Am good if this is regenerated.

@YanxuanLiu
Copy link
Collaborator

build

Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NvTimLiu NvTimLiu marked this pull request as ready for review December 16, 2024 01:46
@YanxuanLiu YanxuanLiu merged commit 22680f5 into branch-24.12 Dec 16, 2024
48 of 49 checks passed
@YanxuanLiu YanxuanLiu deleted the update-changelog branch December 16, 2024 01:55
pxLi added a commit that referenced this pull request Dec 16, 2024
* Update rapids JNI and private dependency to 24.12.0 (#11849)

\nWait for the pre-merge CI job to SUCCEED

Signed-off-by: nvauto <[email protected]>

* Update latest changelog [skip ci] (#11851)

* Update latest changelog [skip ci]

Update change log with CLI: \n\n   scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12

Signed-off-by: nvauto <[email protected]>

* Update changelog

Signed-off-by: Tim Liu <[email protected]>

* update changelog to involve new changes.

Signed-off-by: Yanxuan Liu <[email protected]>

---------

Signed-off-by: nvauto <[email protected]>
Signed-off-by: Tim Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Co-authored-by: Tim Liu <[email protected]>
Co-authored-by: Yanxuan Liu <[email protected]>

* Remove 350db143 shim's build (#11874)

Skip the build of the 350db143 shim, as v24.12.0 will not contain the 350db143 shim

Moreover, the v24.12.0 private dependency jar is not released.

To fix below error:

    [ERROR] Failed to execute goal on project rapids-4-spark-sql_2.12: Could not resolve dependencies for
     project com.nvidia:rapids-4-spark-sql_2.12:jar:24.12.0: Failure to find com.nvidia:rapids-4-spark-private_2.12:jar:spark350db143:24.12.0
     in https://repo1.maven.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Signed-off-by: Tim Liu <[email protected]>

* Update latest changelog [skip ci] (#11876)

Update change log with CLI: \n\n   scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.10,24.12

Signed-off-by: nvauto <[email protected]>

---------

Signed-off-by: nvauto <[email protected]>
Signed-off-by: Tim Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Co-authored-by: Jenkins Automation <[email protected]>
Co-authored-by: Tim Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants