Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]The CHANGELOG is generated based on the project's roadmap rather than the target branch. #11866

Closed
NvTimLiu opened this issue Dec 12, 2024 · 0 comments · Fixed by #11867
Closed

[BUG]The CHANGELOG is generated based on the project's roadmap rather than the target branch. #11866

NvTimLiu opened this issue Dec 12, 2024 · 0 comments · Fixed by #11867
Assignees
@NvTimLiu
Labels
bug Something isn't working

Comments

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Dec 12, 2024 •
edited
Loading

Describe the bug

The CHANGELOG is generated based on the project's roadmap rather than the target branch.

Previously, the CHANGELOG was generated based on the project's roadmap; those PRs without a label are not included in the CHANGELOG.

NOTE: Merged Pull Requests w/o Project:
branch-24.12 #11752 Ability to decompress snappy and zstd Parquet files via CPU [databricks] https://github.com/NVIDIA/spark-rapids/pull/11752
branch-24.12 #11759 Avoid using StringBuffer in single-threaded methods. https://github.com/NVIDIA/spark-rapids/pull/11759
branch-24.12 #11766 Fix Kudo batch serializer to only read header in hasNext https://github.com/NVIDIA/spark-rapids/pull/11766

We need to generate CHANGELOG based on the PR's target branch.

To follow up: #11851 (comment)
@NvTimLiu NvTimLiu added ? - Needs Triage Need team to review and classify bug Something isn't working labels Dec 12, 2024
@NvTimLiu NvTimLiu self-assigned this Dec 12, 2024
NvTimLiu added a commit to NvTimLiu/spark-rapids that referenced this issue Dec 12, 2024
@NvTimLiu
Generate the CHANGELOG based on the PR's target branch
cac4b4b 
To fix: NVIDIA#11866

Generate the CHANGELOG based on the PR's target branch if the PR's project roadmap is empty.

Signed-off-by: Tim Liu <[email protected]>
This was referenced Dec 12, 2024
Merged
Merged
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NvTimLiu NvTimLiu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate the CHANGELOG based on the PR's target branch [skip ci] NvTimLiu/spark-rapids
2 participants
@sameerz @NvTimLiu