Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pynvml is pinned when using TRTLLM v13 due to breaking change in 12.0.0 #485

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix: pynvml is pinned when using TRTLLM v13 due to breaking change in 12.0.0 #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e6c132
fix: pynvml is pinned when using TRTLLM v13 due to breaking change in…
terrykong Jan 17, 2025
24ce9b3
add pynvml/trtllm to requirements.txt
terrykong Jan 17, 2025
2ae486a
Merge branch 'main' into tk/pynvml-fix
terrykong Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ git pull --rebase || true
pip install --no-cache-dir --no-deps -e .
EOF

FROM ${BASE_IMAGE} as final
FROM ${BASE_IMAGE} AS final
LABEL "nemo.library"="nemo-aligner"
WORKDIR /opt
# needed in case git complains that it can't detect a valid email, this email is fake but works
Expand Down Expand Up @@ -70,6 +70,10 @@ RUN git clone https://github.com/NVIDIA/TensorRT-LLM.git && \
pip install -e .
ENV LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/cuda-12/compat/lib.real/

# TODO: This pinning of pynvml is only needed while on TRTLLM v13 since pynvml>=11.5.0 but pynvml==12.0.0 contains a
# breaking change. The last known working verison is 11.5.3
RUN pip install pynvml==11.5.3

# install TransformerEngine
ARG MAX_JOBS
ARG TE_TAG
Expand Down
3 changes: 3 additions & 0 deletions setup/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ jsonlines
megatron_core>=0.8
nemo_toolkit[nlp]
nvidia-pytriton
# pynvml pin is needed for TRTLLM v0.13.0 since 12.0.0 contains a breaking change.
pynvml==11.5.3
tensorrt-llm==0.13.0
Loading