-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pynvml is pinned when using TRTLLM v13 due to breaking change in 12.0.0 #485
Conversation
… 12.0.0 Signed-off-by: Terry Kong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for placing this dependency here instead into the requirements.txt?
At the moment, we install --no-deps, so it actually wouldn't make a difference, but that's a good point that we can also document this in requirements.txt since we'll eventually rely on that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder! SG, I think we’ll anyway be revisiting the dependency management soon
Signed-off-by: Terry Kong <[email protected]>
@ko3n1g Updated requirements.txt + comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change!
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
Checklist when contributing a new algorithm
max_steps=-1
andvalidation
?Additional Information