RdTools 3.0 #390
RdTools 3.0 #390
Conversation
remove warnings from logic clip filter
…nto hour_angle_filter
Updated the xgboost model version + removed experimental filter warnings
update examples and docs for RdTools 3
setup.py
Outdated
| 'sphinx_rtd_theme==0.5.2', | ||
| 'ipython', | ||
| "doc": [ | ||
| "sphinx==8.0.2", |
There was a problem hiding this comment.
sphinx 8.0.2 requires python >= 3.10 but we claim compatibility with python 3.9. I'm ok with keeping this as-is since running docs isn't a core functionality, but if we can bump this down to sphinx==7.4.7 it would retain 3.9 compliance.
There was a problem hiding this comment.
Good catch @cdeline! Looks like we made that change in #428, @martin-springer any input or concerns? Otherwise I'm happy to try it and see if everything works.
There was a problem hiding this comment.
@mdeceglie - I don't think there should be any major issues with downgrading sphinx. The only thing that might happen is that some other doc requirements need to be downgraded as well.
.readthedocs.yml has used python 3.7 in the past, which caused the documentation to fail on the current branch with all the updated packages. Thus, I had to update the python version for the readthedocs workflow and went straight to python 3.12 as we decided this to be our new default.
docs/sphinx/source/changelog.rst
Outdated
| @@ -1,5 +1,6 @@ | |||
| RdTools Change Log | |||
| ================== | |||
| .. include:: changelog/pending.rst | |||
There was a problem hiding this comment.
rename pending.rst to v3.0.0.rst for the release..
|
A couple more changes based on our internal discussions. If this still looks good to everyone, I will update the changelog with 3.0beta, add a date and get this merged to development so we can polish of the soiling changes ahead of the full release. |
Looks good to me! |
__init__.py