Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODS updates #330

Closed
mdeceglie opened this issue Jun 28, 2022 · 5 comments
Closed

CODS updates #330

mdeceglie opened this issue Jun 28, 2022 · 5 comments

Comments

@mdeceglie
Copy link
Collaborator

Before a full release of the CODS algorithm (#150) we should address the following:

  1. pd.concat causes a FutureWarning (see notebook example)
  2. Rename parameters with _tuner in the name
  3. Update the CODS example notebook to use PVDAQ4 data
  4. Add the CODS example notebook to the CI notebook checks
@mdeceglie
Copy link
Collaborator Author

To address item 4, we may need to seed the number random generator

@kandersolar
Copy link
Member

The progress bar text will also be a problem for item 4:
# 16 | Used: 2.2 min | Left: 0.0 min | Progress: [----------------------------->] 100 %

We could add a new "sanitization" regex in docs/nbval_sanitization_rules.cfg to deal with that. Or just remove the progress bar from the notebook (verbose=False).

@kandersolar
Copy link
Member

I think the docstring description of the results_dict returned from iterative_signal_decomposition need some tweaks: the degradation and soiling_loss keys are described as containing lists but the actual return values are scalars.

@mdeceglie
Copy link
Collaborator Author

#333 addressed items 1 and 2 here. 3 and 4 should still be addressed before a real release.

@mdeceglie
Copy link
Collaborator Author

Items 3 and 4 added in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants