Implement NOVA-Worldgen #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Wrappers
EnumSelector will be removed if NOVA-Team/NOVA-Monorepo#232 is merged.
This was referenced Jan 2, 2017
Victorious3
reviewed
Jan 3, 2017
| // DEEPERER = 20 (15-25) | ||
| // REALLYDEEP = 10 (5-15) | ||
|
|
||
| if (ore.oreLayers.allows(OreHeight.SURFACE)) |
RX14
reviewed
Jan 3, 2017
| oreHeightMap.put(j++, OreHeight.REALLYDEEP); | ||
| Iterator<OreHeight> iterator = Arrays.stream(OreHeight.values()).filter(ore.oreLayers::allows).iterator(); | ||
|
|
||
| for (OreHeight height = iterator.next(); iterator.hasNext();) { |
There was a problem hiding this comment.
Fixed now.
The main reason I did it that way initially, is because I made use of the local variable j, which must be final or effectively final to be used in lambda expressions.
Reason: Consistency with already implemented wrappers
Reason: Worldgen is not just ores.
Additional changes: OreGenerationRegistry was replaced with Registry<Ore>, as it was redundant.
17 tasks
This was referenced Jan 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains my implementation of NOVA-Worldgen wrappers and WorldManager.
Depends on NOVA-Team/NOVA-Monorepo#229, NOVA-Team/NOVA-Monorepo#231 and NOVA-Team/NOVA-Monorepo#232.
To do list:
Implement(Leave that for another PR)WorldInfoCompleted:
WorldgenManagerdependency injection