[RFC] Move events to their correct event class as inner classes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # minecraft/1.8/src/main/java/nova/core/wrapper/mc/forge/v18/wrapper/block/forward/FWBlockSound.java
Current coverage is 13.76% (diff: 33.33%)@@ master #233 diff @@
==========================================
Files 387 387
Lines 10839 10842 +3
Methods 0 0
Messages 0 0
Branches 1547 1547
==========================================
+ Hits 1491 1492 +1
- Misses 9271 9273 +2
Partials 77 77
|
ExE-Boss
added
breaking change
RX14
approved these changes
Jan 9, 2017
|
Cleaned up and merged into master |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some work on #192.
Depends on:
String -> Identifier. WIP. #229(dependency removed)To do list:
Consider moving other events as well(Leave that for another PR)Completed:
ItemRegistrationEventtoItemEventasItemEvent.RegisterItemIDNotFoundEventtoItemEventasItemEvent.IDNotFound