[RFC] Move all remaining events to their correct event class as inner classes #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
added
breaking change
ExE-Boss
force-pushed
the
refactor/move-events
branch
from
48d09c9 to
105bf9f
Compare
ExE-Boss
force-pushed
the
refactor/move-events
branch
from
105bf9f to
f422465
Compare
Current coverage is 14.17% (diff: 10.00%)@@ master #253 diff @@
==========================================
Files 395 394 -1
Lines 11148 11150 +2
Methods 0 0
Messages 0 0
Branches 1586 1586
==========================================
- Hits 1582 1581 -1
- Misses 9480 9483 +3
Partials 86 86
|
ExE-Boss
added
ready
RX14
approved these changes
Jan 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192 and completes #233.
Completed:
RecipeAddedEventtoRecipeEventasRecipeEvent.AddRecipeRemovedEventtoRecipeEventasRecipeEvent.RemoveRecipeEvent.AddandRecipeEvent.RemoveextendRecipeEventRecipeEventextendCancelableEventNo more orphaned event classes have been found.
Events in
Block,ItemandEntitywere left there, as they are bound to theBlock,ItemorEntityinstance.