Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimal python version to 3.11 #27

Merged

Conversation

romanc
Copy link

@romanc romanc commented Sep 2, 2024

Description

PyFV3 requires a minimum python version 3.11. This was updated two months ago. This commit cleans up the following two leftovers:

  1. In setup.py, update the classifiers
  2. In the Dockerfile, start from the python 3.11 image

How Has This Been Tested?

Tested by running make build locally. Before this change, the command would fail (because of the numpy and pyFV3's setup.py dependency to python >= 3.11). With this change, I can build the docker image and run savepoint tests.

Note: running make savepoint_tests fails before and after this change with the same error summary.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

pyFV3 requires a minimum python version 3.11. This was updated two
months ago. This commit cleans up the following two leftovers:

1. In `setup.py`, update the classifiers
2. In the `Dockerfile`, start from the python 3.11 image
@romanc
Copy link
Author

romanc commented Sep 2, 2024

@FlorianDeconinck can you please review (once you are back tomorrow)?

@FlorianDeconinck
Copy link
Collaborator

@mlee03 This (slightly) touches the Docker file in pyFV3 that you might be using for CI

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianDeconinck FlorianDeconinck merged commit e49917d into NOAA-GFDL:develop Sep 3, 2024
4 checks passed
@romanc romanc deleted the romanc/update-python-3.11 branch September 3, 2024 12:58
@romanc romanc mentioned this pull request Nov 12, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants