Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pass in setup.py #28

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

romanc
Copy link

@romanc romanc commented Nov 12, 2024

Description

This PR does a pass on the setup.py file and changes the following

This is a follow-up from a couple of PRs and mentions including

How Has This Been Tested?

Tested python_requires locally (with different python version and multiple virtual environments)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

@romanc romanc marked this pull request as draft November 12, 2024 14:48
- Fully move from AI2 to NOAA-GDFL
- Restrict python version to 3.11
- Consistent license information
- Pin NDSL at latest release (2024.09.00)
@romanc romanc marked this pull request as ready for review November 12, 2024 15:54
@romanc
Copy link
Author

romanc commented Nov 13, 2024

@fmalatino @oelbert would you mind to review this? And can someone else add Rusty to the list of reviewers? I can't seem to find him.

I'd add you guys as reviewers if I could. Looks like I don't have the rights to do this.

/cc @FlorianDeconinck as discussed.

fmalatino
fmalatino previously approved these changes Nov 13, 2024
oelbert
oelbert previously approved these changes Nov 13, 2024
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for taking care of this.

setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@romanc romanc dismissed stale reviews from oelbert and fmalatino via 1f8ed0b November 13, 2024 17:04
setup.py Outdated Show resolved Hide resolved
This was added a while back (at AI2) when - for a brief amount of time -
the idea as to ship some translate test data with the package. This idea
was rejected and now the configuration option isn't needed anymore.
@romanc
Copy link
Author

romanc commented Nov 14, 2024

Thanks for all the discussions. This is ready for a second round of reviews.

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romanc
Copy link
Author

romanc commented Nov 15, 2024

Someone with write access to the repo will need to merge this PR. I don't have the rights to do this.

@FlorianDeconinck FlorianDeconinck merged commit 819c5b2 into NOAA-GFDL:develop Nov 15, 2024
4 checks passed
@romanc romanc deleted the romanc/cleanup-setup-py branch November 15, 2024 14:00
@bensonr bensonr mentioned this pull request Nov 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants