Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a special property to make "negation" of edges more visible in a TRAPI message #407

Open
wants to merge 4 commits into
base: 1.4
Choose a base branch
from

Conversation

sierra-moxon
Copy link
Member

We discussed in the modeling group how to represent a 'negated' edge in our models either as a negated form of each of our predicates, e.g. predicate: not_affects and predicate: affects or as an edge property negation. Ultimately, the DM group decided to include a negation edge property (revisit the discussion and vote here), with the caveat that negation should never be ignored downstream and should always be shown. Right now in TRAPI, the negation edge property would be treated in TRAPI like any other attribute.

Groups making negated edges still express concern that the negation property will be ignored or less visible than necessary for groups downstream (and ultimately users). This PR attempts to give more transparency to the negation property via a specific property on an edge, as well as adding a flag to MetaEdge so that a resource an alert users that an edge might have both positive and negated edges.

@edeutsch
Copy link
Collaborator

See also PR #307, which is a little different. That PR includes the idea of adding negated to QueryEdge, too, which probably should be part of it?

@sierra-moxon
Copy link
Member Author

Thank you for the pointer; I missed the QEdge. :) I merged that PR branch into this one, but happy to go the other way instead if that makes more sense.

Copy link
Collaborator

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for merging, this looks good to me. I will close #307 in favor of this, but note that there is some good discussion over there that should be acknowledged.

@sierra-moxon
Copy link
Member Author

Link to @cmungall's comments on negation of an edge from PR #307 : #307 (comment)

@edeutsch edeutsch added this to the v1.5 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants