Introduce a special property to make "negation" of edges more visible in a TRAPI message #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed in the modeling group how to represent a 'negated' edge in our models either as a negated form of each of our predicates, e.g.
predicate: not_affects
andpredicate: affects
or as an edge propertynegation
. Ultimately, the DM group decided to include anegation
edge property (revisit the discussion and vote here), with the caveat thatnegation
should never be ignored downstream and should always be shown. Right now in TRAPI, thenegation
edge property would be treated in TRAPI like any otherattribute
.Groups making negated edges still express concern that the negation property will be ignored or less visible than necessary for groups downstream (and ultimately users). This PR attempts to give more transparency to the
negation
property via a specific property on an edge, as well as adding a flag to MetaEdge so that a resource an alert users that an edge might have both positive and negated edges.