Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose QEdge.negated and Edge.negated #307

Closed
wants to merge 1 commit into from
Closed

Conversation

edeutsch
Copy link
Collaborator

@edeutsch edeutsch commented Dec 1, 2021

Addresses #281

@edeutsch
Copy link
Collaborator Author

2021-12-16 DECISION: Hold until BioLink finalizes their process.

@cmungall
Copy link
Contributor

cmungall commented Feb 9, 2022

Negation and predicate hierarchies

Consider:

  1. Query: A NOT interacts-with B
  2. KP Assertion: A NOT phosphorylates B

(where phosphorylates is a subpredicate of interacts-with)

What is the interpretation of 1?

  • 1a: Loose interpretation: Find all negative statements relating A and B, where the relationship is some kind of interaction relationship
  • 1b: Strict logical interpretation: What statements explicitly make the claim that A does not interact-with B

For 1a, (loose interpretation) implementors should include all assertion A NOT R B, where R is a reflexive transitive subproperty of interacts-with, i.e. the same algorithm as for positive assertions. Here assertion 2 WOULD be returned

For 1b, implementors essentially invert the procedure for positive statements. Here assertion 2 WOULD NOT be returned

We can also explore the reverse situation

1 . Query: A NOT phosphorylates B
2. KP Assertion: A NOT interacts-with B

Here 2 is logically entailed by 1

Negation and class hierarchies

  1. Query: ?drug NOT has-side effect coughing
  2. KP assertion: drugA NOT has-effect respiratory-system-phenotype (i.e. no respiratory system phenotypes)
  3. ontology: coughing subClassOf respiratory-system-phenotype

Under the logical interpretation, 1 is entailed by 2 and 3, so drugA will be returned. Note this involves reversing the traversal direction for a positive query

@edeutsch
Copy link
Collaborator Author

Closing in favor of a more comprehensive PR #407

@edeutsch edeutsch closed this Mar 21, 2023
@edeutsch edeutsch deleted the edeutsch-negated branch May 28, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants