Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel-1 VV VH backscatter DA (REWORKED) #1415

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cmclaug2
Copy link
Contributor

Description

This PR is a reworked version of #1208
This PR:

  • Extracts the testcase that was added to the source code
  • Updates documentation
  • Reverts Config.pl to the Main branch
  • Removes unnecessary NaN check in LIS_historyMod.F90

Addresses #1192
Addresses #1012

Testcase

I have confirmed this replicates the testcase in #1208
I have confirmed this compiles with strict checks.

mbechtold and others added 6 commits August 24, 2022 15:53
+ Updates documentation
+ Undos the changes made by KUL to Config.pl
+ Removed unneeded check for NaNs in LIS_historyMod.F90
The prior commit did not use Config.pl from the Main branch.
@jvgeiger
Copy link
Contributor

When compiled with GNU compilers, LIS crashes in enkf_Mod.F90 at line 319 with the message:

Error in `./LIS': malloc(): memory corruption:

When compiled with Intel compilers with additional debugging enabled, LIS crashes in LIS_DAobservationsMod.F90 at line 2051 with the message:

forrtl: severe (408): fort: (3): Subscript #2 of the array LIS_OBS_NGRIDS has value -1 which is less than the lower bound of 0

In S1_sigmaVVVHSMLAI/S1_sigmaVVVHSMLAI_Mod.F90, flist is used uninitialized. This file also uses ls to create a list of files. This should be replaced with a call to create_filelist.

@jvgeiger jvgeiger self-assigned this Oct 12, 2023
jvgeiger added a commit to KathyNie/LISF that referenced this pull request Dec 8, 2023
This bug fix is from Michel Bechtold and Samuel Scherrer.  See PR NASA-LIS#1415.
@mbechtold
Copy link

Hi @jvgeiger
I addressed the issues that you raised in this PR cmclaug2#1 for the branch of @cmclaug2. Results are zero-diff.
The only thing I could not test is the compilation with the GNU compiler. Hope the memory corruption is fixed as well. Let me know if there is anything else I can do to finalize this PR.
Thanks!

@mbechtold
Copy link

@dmocko @sujayvkumar @cmclaug2 @jvgeiger
In February, I added this note to the PR. Would be great if this PR could eventually be merged soon to make this DA instance easily accessible for other LIS users.

@jvgeiger
Copy link
Contributor

Hello. I apologize for the delay. We get to pull requests, issues, and discussions when time permits. Unfortunately, other tasks kept coming up. I will review your bug fixes and finish this pull request as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants