feat: Implement page footer with USWDS components #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
renamed old footer to PageFooterLegacy
I suppose the content will be included in the new footer component
Contributes to the feature branch #1285 Hej @snmln ! Thanks for setting up the feature branch and foundations for the new footer component! I renamed the old footer to PageFooterLegacy, that way we can use the regular import path for our new footer component. Also added a .env var that allows us to switch between old and new footer implementations easily. Campground Rule[^1]: While working on the feature flag, I addressed an unrelated lint warning within the files I made changes to. [^1]: Always leave the campground cleaner than you found it.
AliceR
changed the title
AliceR
reviewed
Dec 9, 2024
**Related Ticket:** _{link related ticket here}_
### Description of Changes
Creating slim footer.
- Establishing initial Front-end
- Creating footer object model in veda.config.js
- Setting up initial default.config.js
- Wiring up Config data flow
- Turning USWDS breakpoints on
TO DO's for this PR:
- Implement dynamic creation of links in footer component
AliceR
added
the
design system change
|
@faustoperez Can you take a look at the preview view here: https://deploy-preview-1285--veda-ui.netlify.app/ We have the front-end in place and are currently working through functionality. So this should be in a good spot for a design review. |
This reverts commit d830c03.
AliceR
reviewed
Dec 16, 2024
| type='button' | ||
| tabIndex={0} | ||
| id={item.id} | ||
| onClick={show} | ||
| style={{background: 'none', border: 'none', cursor: 'pointer'}} | ||
| style={{ background: 'none', border: 'none', cursor: 'pointer' }} |
There was a problem hiding this comment.
what was the reason for using inline styles?
|
Style problems detected over in next-veda-ui (developmentseed/next-veda-ui#26):
|
Creating initial test suite
I am adding some more fields to the secondary section in the footer section, in order to have any text content configurable: Added `division`, `version`, and `name`, repurposed `title`. I'd be curious to know how other instances might use and configure the footer, this could better inform naming decisions (e.g. `division`?).
|
@AliceR I have corrected the issues on the nextjs instance. Heads up on one of the bullet points:
This is an issue with the content section not respecting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1135
Description of Changes
TO DO:
Checkin with Fausto on progress.Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}