Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Layout Components - Footer #1135

Open
4 tasks
aboydnw opened this issue Aug 29, 2024 · 4 comments · May be fixed by #1285
Open
4 tasks

[Refactor] Layout Components - Footer #1135

aboydnw opened this issue Aug 29, 2024 · 4 comments · May be fixed by #1285
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@aboydnw
Copy link
Contributor

aboydnw commented Aug 29, 2024

Context

This ticket is for a layout component as part of the VEDA refactor. This components are used to generate the overall layout and site architecture of the Dashboard. They match the overall look and feel of the app and will be used in the template instance. Our recommendation will be to use these layout components, and we anticipate that most instances will use these components, but some may decide to bring their own.

Our footer implementation on GHG is probably the most recent and complete implementation so far. This also depends on the design ticket #1123

This ticket might be broken down into smaller tickets after initial investigation.

Notes:

  • Mark new files for VEDA2 refactor with @VEDA2-REFACTOR-WORK

Acceptance Criteria:
General

  • Reusability => modularize stateless/presentational features to be as reuseable as possible within the core feature view containers
  • Composite Feature should be entirely data agnostic => Separate out the data logic from this feature component into the data layer. Note: Data will now have to be passed in as props so we will need to update the page views to supply this
    • Composite Features should have stricter typed interfaces
  • This feature should still support current instances and be backwards compatible

Specific
{TO BE UPDATED}

Related to: #801

Resources:

@aboydnw aboydnw added the veda v2 VEDA Refactor Epic Work label Aug 29, 2024
@snmln
Copy link
Contributor

snmln commented Dec 3, 2024

@aboydnw & @faustoperez I wanted to confirm are these the design that we should be working off of?

Design: https://www.figma.com/design/PG7AhRloW6qJd9U00VdQ77/VEDA-Template-Instance?node-id=178-2&t=HAlyBRbfjH7jZgHy-1

@snmln snmln linked a pull request Dec 3, 2024 that will close this issue
11 tasks
@aboydnw
Copy link
Contributor Author

aboydnw commented Dec 3, 2024

Yes sorry I should have update this ticket with that most recent link. I believe most recent designs for the footer happened during this ticket: #1193
That has the same figma link that you shared @snmln

@faustoperez correct me if that's wrong or if there is a better figma link

@faustoperez
Copy link

Please use the VEDA - USWDS Figma file for components, the one you list is the Template instance file

This is the correct link: https://www.figma.com/design/5mclPTReHcRIzKbJm8YA6a/VEDA---USWDS?node-id=473-586&t=dOX6eKbhgXYNuNu3-1

Thank you!

@AliceR AliceR linked a pull request Dec 9, 2024 that will close this issue
11 tasks
@faustoperez
Copy link

I have updated the VEDA-USWDS Figma file with the mobile footer designs 👉 https://www.figma.com/design/5mclPTReHcRIzKbJm8YA6a/VEDA---USWDS?node-id=473-586&t=NsDEcNxf1omkNZTF-1

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants