Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exploration types file name and imports #1273

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/scripts/components/common/blocks/block-map.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
VizDataset,
VizDatasetSuccess,
DatasetStatus
} from '$components/exploration/types.d.ts';
} from '$components/exploration/types.d';

import {
reconcileDatasets,
Expand Down Expand Up @@ -181,7 +181,7 @@
totalLayers = [...totalLayers, compareMapStaticData];
}
return totalLayers;
}, [layerId]);

Check warning on line 184 in app/scripts/components/common/blocks/block-map.tsx

View workflow job for this annotation

GitHub Actions / lint

React Hook useMemo has a missing dependency: 'datasetLayers'. Either include it or remove the dependency array

const [layers, setLayers] = useState<VizDataset[]>(layersToFetch);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import {
DatasetStatus,
VizDataset,
VizDatasetSuccess
} from '$components/exploration/types.d.ts';
} from '$components/exploration/types.d';
import { useReconcileWithStacMetadata } from '$components/exploration/hooks/use-stac-metadata-datasets';
import {
formatSingleDate,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/components/common/map/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
DatasetStatus,
DatasetData,
VizDataset
} from '$components/exploration/types.d.ts';
} from '$components/exploration/types.d';
import { fixAntimeridian } from '$utils/antimeridian';

export const FIT_BOUNDS_PADDING = 32;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import endOfYear from 'date-fns/endOfYear';
import startOfDay from 'date-fns/startOfDay';
import startOfMonth from 'date-fns/startOfMonth';
import startOfYear from 'date-fns/startOfYear';
import { TimeDensity } from '$components/exploration/types.d.ts';
import { TimeDensity } from '$components/exploration/types.d';

/**
* Calculate the start and end of a block of time, given a date and a time
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
LayerCategoricalGraphic, LayerGradientColormapGraphic
} from '$components/common/map/layer-legend';

import { TimelineDataset } from '$components/exploration/types.d.ts';
import { TimelineDataset } from '$components/exploration/types.d';
import { CollecticonDatasetLayers } from '$components/common/icons/dataset-layers';
import { ParentDatasetTitle } from '$components/common/catalog/catalog-content';
import { checkEnvFlag } from '$utils/utils';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { getNumForChart } from '$components/common/chart/utils';
import {
TimelineDatasetAnalysisSuccess,
TimelineDatasetSuccess
} from '$components/exploration/types.d.ts';
} from '$components/exploration/types.d';

const CHART_MARGIN = 8;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { findDatasetAttribute } from '$components/exploration/data-utils';
import {
DatasetStatus,
TimelineDatasetSuccess
} from '$components/exploration/types.d.ts';
} from '$components/exploration/types.d';
import {
DATASET_TRACK_BLOCK_HEIGHT,
HEADER_COLUMN_WIDTH
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { TipButton } from '$components/common/tip-button';
import { timelineDatasetsAtom } from '$components/exploration/atoms/datasets';
import { useTimelineDatasetSettings } from '$components/exploration/atoms/hooks';
import { NativeSliderInput, SliderInputProps } from '$styles/range-slider';
import { TimelineDataset } from '$components/exploration/types.d.ts';
import { TimelineDataset } from '$components/exploration/types.d';


interface LayerMenuOptionsProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import startOfYear from 'date-fns/startOfYear';
import { themeVal } from '@devseed-ui/theme-provider';

import { RIGHT_AXIS_SPACE } from '$components/exploration/constants';
import { TimeDensity } from '$components/exploration/types.d.ts';
import { TimeDensity } from '$components/exploration/types.d';

const GridLine = styled.line`
stroke: ${themeVal('color.base-200')};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { glsp, themeVal } from '@devseed-ui/theme-provider';

import { TIMELINE_PLAYHEAD_COLOR_LABEL, TIMELINE_PLAYHEAD_COLOR_PRIMARY, TIMELINE_PLAYHEAD_COLOR_SECONDARY, TIMELINE_PLAYHEAD_COLOR_TEXT } from './timeline-controls';
import { RIGHT_AXIS_SPACE } from '$components/exploration/constants';
import { DateRange } from '$components/exploration/types.d.ts';
import { DateRange } from '$components/exploration/types.d';

// Needs padding so that the timeline head is fully visible.
// This value gets added to the width.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ScaleTime, Selection, ZoomBehavior, ZoomTransform } from 'd3';
import { TimelineDatasetSuccess } from '$components/exploration/types.d.ts';
import { TimelineDatasetSuccess } from '$components/exploration/types.d';

/**
* Clamps the given value to the given range.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ import {
DatasetStatus,
TimelineDatasetSuccess,
ZoomTransformPlain
} from '$components/exploration/types.d.ts';
} from '$components/exploration/types.d';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandrahoang686 do these need to be changed to types.d.ts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the file name change in this pr it appears app/scripts/components/exploration/types.d.ts to be accurately changes to the previous name.

import { useInteractionRectHover } from '$components/exploration/hooks/use-dataset-hover';
import { useAnalysisController } from '$components/exploration/hooks/use-analysis-data-request';
import useAois from '$components/common/map/controls/hooks/use-aois';
Expand Down
Loading