Fix exploration types file name and imports #1273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrahoang686
requested review from
dzole0311,
hanbyul-here,
snmln and
AliceR
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snmln
reviewed
Nov 26, 2024
| @@ -63,7 +63,7 @@ import { | |||
| DatasetStatus, | |||
| TimelineDatasetSuccess, | |||
| ZoomTransformPlain | |||
| } from '$components/exploration/types.d.ts'; | |||
| } from '$components/exploration/types.d'; | |||
There was a problem hiding this comment.
@sandrahoang686 do these need to be changed to types.d.ts?
There was a problem hiding this comment.
Looking at the file name change in this pr it appears app/scripts/components/exploration/types.d.ts to be accurately changes to the previous name.
|
I am a bit unclear what this PR is trying to address - ts-check is not passing since some files are still using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this happened but heres a fix