Convert MapScreen
and WaypointCreationScreen
to NUI
#669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request converts the
MapScreen
andWaypointCreationScreen
UIs to use NUI.Before
After
Testing
Functional Tests
Map Viewing
Map
button or by pressing theTab
key).Zoom In
button.Zoom Out
button.Waypoints
Marker+
button is pressed and a position chosen.Cancel
should not place a waypoint.Done
should place a waypoint.Marker-
button and then selecting a waypoint should remove that waypointVisual/Scale Testing
Android builds will not see as significant a difference here because they use automatic screen scaling based on the reported display density.
Notes
EmptyIfInvisibleContainer
,UIBackingBox
andUILabelledIcon
) #664.