Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MapScreen and WaypointCreationScreen to NUI #669

Conversation

BenjaminAmos
Copy link
Contributor

Description

This pull request converts the MapScreen and WaypointCreationScreen UIs to use NUI.

Before

image

After

image

Testing

Functional Tests

Map Viewing

  • Start a new game or continue an existing one.
  • Open the map screen (either using the Map button or by pressing the Tab key).
  • Try zooming-in by scrolling the mouse wheel forwards.
  • Try zooming-in by clicking the Zoom In button.
  • Try zooming-out by scrolling the mouse wheel backwards.
  • Try zooming-out by clicking the Zoom Out button.
  • Pan the map by holding the left-mouse button on it and dragging the mouse in the desired pan direction.

Waypoints

  • The waypoint creation screen should be displayed when the Marker+ button is pressed and a position chosen.
  • The three sliders on the waypoint screen should be adjustable from 0 to 255.
  • The colour shown at the top of the waypoint screen should correspond to the chosen slider values.
  • Clicking Cancel should not place a waypoint.
  • Clicking Done should place a waypoint.
  • The placed waypoint should contain the colour chosen.
  • Clicking the Marker- button and then selecting a waypoint should remove that waypoint

Visual/Scale Testing

  • Try to view the screen on different form-factors and screen resolutions.
    Android builds will not see as significant a difference here because they use automatic screen scaling based on the reported display density.
  • Elements should not be significantly overlapping.
  • Text should ideally not be wrapping mid-word.
  • Buttons should be large enough to be confortable to reach on Android.

Notes

@BenjaminAmos BenjaminAmos changed the base branch from develop to nui-ported-screens October 31, 2022 22:53
@BenjaminAmos BenjaminAmos force-pushed the nui-screen-conversion/map-screen branch from 0f8d97d to ccb2cbf Compare November 1, 2022 00:06
@BenjaminAmos BenjaminAmos merged commit 6b71f15 into MovingBlocks:nui-ported-screens Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant