Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported the majority of UIs to NUI #672

Merged
merged 14 commits into from
Dec 4, 2022
Merged

Ported the majority of UIs to NUI #672

merged 14 commits into from
Dec 4, 2022

Conversation

BenjaminAmos
Copy link
Contributor

Description

This pull request converts the majority of UI interfaces over to use NUI. There are still a few things still using the previous UI classes where equivalent functionality is not present in NUI.

This is an aggregation of several pull requests which individually port over each screen:

This also brings-back the ability charges bar, which was broken in 2.0.0.

You can view a visual comparison of the changes here.

Testing

See the individual PRs for testing information for each screen.

Potential Future Improvements

  • The UIWarnDrawer notifications are not the most visually pleasant. Better placement and design is needed but for now I've tried to retain most lf the original appearance and behaviour.
  • UIWarnDrawer notifications start from the middle of the screen on Android, which shouldn't really be the case.

Breaking Changes

  • The original GameScreens#mainGameScreen variable has been re-named to GameScreens#oldMainGameScreen.
  • GameScreens#mainGameScreen now points to the NUI version of MainGameScreen instead.

Notes

@BenjaminAmos BenjaminAmos merged commit 3043c3d into develop Dec 4, 2022
@BenjaminAmos BenjaminAmos deleted the nui-ported-screens branch December 4, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Adapt existing UI screens to use NUI
1 participant