Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcFrameworks: Set force flag on static libs #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

xcFrameworks: Set force flag on static libs #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/compiler/src/main/java/org/robovm/compiler/config/ResolvedLocations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ private void processXCFramework(File xcFrameworkLocation, List<File> destLocatio
} else if (libPath.endsWith(".a")) {
// static library inside .xcframework, add it to libs
File staticLibFile = new File(new File(xcFrameworkLocation, library.getIdentifier()), libPath);
destLibs.add(new Config.Lib(staticLibFile.getAbsolutePath(), false));
destLibs.add(new Config.Lib(staticLibFile.getAbsolutePath(), true));
} else {
String message = String.format(
"Unsupported library type %s matched %s %s, in '%s'",
Expand Down
4 changes: 2 additions & 2 deletions compiler/compiler/src/test/java/org/robovm/compiler/config/ConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ public void testXCFrameworkLookupResolvedIntoStaticLib() throws Exception {
assertEquals(Collections.singletonList(frameworkLocation), config.getFrameworkPaths());
assertEquals(Collections.emptyList(), config.getFrameworks());
assertEquals(Arrays.asList(
new Lib(new File(xcFramework, "ios-x86_64-simulator/library-static3.a").getAbsolutePath(), false)),
new Lib(new File(xcFramework, "ios-x86_64-simulator/library-static3.a").getAbsolutePath(), true)),
config.getLibs());
}

Expand Down Expand Up @@ -591,7 +591,7 @@ public void testXCFrameworkResolved() throws Exception {
assertEquals(Collections.singletonList(frameworkLocation), config.getFrameworkPaths());
assertEquals(Collections.emptyList(), config.getFrameworks());
assertEquals(Arrays.asList(
new Lib(new File(xcFramework, "ios-x86_64-simulator/library-static3.a").getAbsolutePath(), false)),
new Lib(new File(xcFramework, "ios-x86_64-simulator/library-static3.a").getAbsolutePath(), true)),
config.getLibs());
}

Expand Down