xcFrameworks: Set force flag on static libs #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasisdormax
force-pushed
the
force-xcframework-static-libs
branch
from
c324aaf to
cd0c98f
Compare
|
hi, we should not force all static libs unconditionally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets the force flag on static libraries included from an xcFramework.
My Reasoning
My project uses ZSTD included as a static library and I recently tried to switch it from a regular lib to an xcframework (for arm-simulator support). Without this, the ZSTD symbols would be missing from the binary.
This is the minimal implementation that works with my setup. If you think a 'force' option on the xcframework path is needed instead, I could implement that instead.