* libmobiledevice maintenance: waiting for device and error handling #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: libmobiledevice was failing on every situation then: device is not connected, blocked or pairing not complete. considering build process and deployment might take minutes its sad to fail just due to blocked device. changes: mitigation for these cases done by allowing 20 seconds for user to act to solve the situation: - if no device connected -- waiting for device - if device is locked -- waiting for unlock - if pairing in progress -- waiting to complete other changes: - changed logic for picking dev image -- all version are parsed and picked exact or lower (fix for MobiVM#517) - idea plugin: install was moved inside Run process. As before it was happening on UI thread and entire Idea was frozen (there was no update or locked device retries message); - using Java9 language level for RoboVM compiler/plugins. - amount for TODO added to point for code fragments that to be refactored (like Launchers, junit client depends on old structure)
This was referenced May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason
(also possibly fixes part of #721 issues)
libmobiledevice was failing on every situation then: device is not connected, blocked or pairing not complete. considering build process and deployment might take minutes its sad to fail just due to blocked device. changes: mitigation for these cases done by allowing 20 seconds for user to act to solve the situation:
now it looks as bellow in RoboVM log window:
other changes