Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra rollen tekstjes #506

Merged
merged 15 commits into from
Dec 19, 2024
Merged

Extra rollen tekstjes #506

merged 15 commits into from
Dec 19, 2024

Conversation

noutvandeijck
Copy link
Collaborator

Beschrijf jouw aanpassingen

Tekstjes voor de rollen:

  • beleid en advies
  • jurist

Bij welk issue hoort deze pull-request?

#410

Checklist before requesting a review

  • Ik heb de contributing guidelines van deze repository gelezen en gevolgd.
  • Ik heb mijn aanpassingen gecheckt op spelfouten.
  • Als ik gebruik heb gemaakt van links, dan heb ik gecheckt of deze werken.
  • Ik heb gebruik gemaakt van de templates en formats van het algoritmekader.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-19 09:18 UTC

@BartdeVisser BartdeVisser self-assigned this Dec 18, 2024
BartdeVisser
BartdeVisser reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@BartdeVisser BartdeVisser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paar kleine nuances doorgevoerd.

docs/rollen/beleid-en-advies.md Outdated Show resolved Hide resolved
docs/rollen/beleid-en-advies.md Outdated Show resolved Hide resolved
docs/rollen/jurist.md Outdated Show resolved Hide resolved
@BartdeVisser BartdeVisser added this to the Release v2.0 milestone Dec 18, 2024
@noutvandeijck noutvandeijck force-pushed the release-v2.0/extra-rollen-tekstjes branch from 354d98a to d75fca0 Compare December 18, 2024 15:33
@webredactie-algoritmekader
Copy link
Collaborator

@BartdeVisser: Kun jij je er zo in vinden? Heb de tekstjes anders opgezet, Daarom was het lastig om te syncen met jouw opmerkingen. Misschien zie je zelf in 1 oogopslag waar die wijzigingen nog horen (als je deze opzet geslaagd vindt natuurlijk)?

@noutvandeijck noutvandeijck marked this pull request as ready for review December 18, 2024 18:26
@BartdeVisser BartdeVisser merged commit 9b8403e into main Dec 19, 2024
1 check passed
@ruthkoole ruthkoole deleted the release-v2.0/extra-rollen-tekstjes branch January 8, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartdeVisser BartdeVisser BartdeVisser approved these changes

@ruthkoole ruthkoole Awaiting requested review from ruthkoole ruthkoole is a code owner

Assignees

@BartdeVisser BartdeVisser

Labels
None yet
Projects
None yet
Milestone
Release v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@noutvandeijck @webredactie-algoritmekader @BartdeVisser