Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OCP bundle #57

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat: add OCP bundle #57

merged 1 commit into from
Dec 30, 2024

Conversation

almaslennikov
Copy link
Collaborator

  • build OCP bundle
  • configure operator configmap via kustomize
  • add required RBAC permissions to operate in openshift
  • add a github action to build and push the bundle to ghcr on a new tag

@coveralls
Copy link

coveralls commented Dec 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12480427450

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.088%
Totals Coverage Status
Change from base Build 12429770632: 0.0%
Covered Lines: 1879
Relevant Lines: 3180
💛 - Coveralls

@almaslennikov almaslennikov force-pushed the ocp branch 2 times, most recently from 2400250 to 2580e64 Compare December 20, 2024 10:28
e0ne
e0ne requested changes Dec 20, 2024
View reviewed changes
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/metadata/annotations.yaml Show resolved Hide resolved
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
rollandf
rollandf reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@rollandf rollandf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about that but I think that the operator image should use ubi as base image for OpenShift

Guide from Red Hat:
https://docs.redhat.com/en/documentation/red_hat_software_certification/2024/html/red_hat_openshift_software_certification_policy_guide/assembly-products-managed-by-an-operator_openshift-sw-cert-policy-container-images#con-operator-requirements_openshift-sw-cert-policy-products-managed

bundle/manifests/nic-configuration-operator-config_v1_configmap.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated
NICs there.
displayName: NVIDIA NIC Configuration Operator
icon:
- base64data: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an icon.

For example:
https://github.com/redhat-openshift-ecosystem/certified-operators/blob/main/operators/nvidia-network-operator/24.1.0/manifests/nvidia-network-operator.clusterserviceversion.yaml#L132

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably request one from the product designers (I guess). Let's skip it for now and add once available to us before creating a PR to certified operators

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.
Maybe @e0ne remembers how we got one for Network Operator

bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/nic-configuration-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
@rollandf rollandf mentioned this pull request Dec 24, 2024
Open
@almaslennikov almaslennikov force-pushed the ocp branch 3 times, most recently from 4efb9ae to 394a4d7 Compare December 24, 2024 10:09
@almaslennikov almaslennikov force-pushed the ocp branch 2 times, most recently from 78379b4 to 0b723b5 Compare December 24, 2024 10:16
@almaslennikov
feat: add OCP bundle
c5d8e86 
- build OCP bundle
- configure operator configmap via kustomize
- add required RBAC permissions to operate in openshift
- add a github action to build and push the bundle to ghcr on a new tag

Signed-off-by: Alexander Maslennikov <[email protected]>
@almaslennikov almaslennikov merged commit 8c279d4 into Mellanox:main Dec 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e0ne e0ne e0ne requested changes

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

@rollandf rollandf rollandf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@almaslennikov @coveralls @e0ne @rollandf @ykulazhenkov