-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OCP bundle #56
base: main
Are you sure you want to change the base?
Conversation
almaslennikov
commented
Dec 20, 2024
- generate bundle using Makefile
- build and push bundle using GH actions on new tag
ca9690a
to
27c75af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as in Mellanox/nic-configuration-operator#57
bundle/manifests/maintenance-operator-controller-manager-metrics-service_v1_service.yaml
Outdated
Show resolved
Hide resolved
.../manifests/maintenance-operator-metrics-reader_rbac.authorization.k8s.io_v1_clusterrole.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/maintenance-operator-controller-manager-metrics-service_v1_service.yaml
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 12647746508Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Request changes' clicked for missing 'nic-configuration-operator-daemon' image in relatedImages section
bundle/manifests/nvidia-maintenance-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/nvidia-maintenance-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
- generate bundle using Makefile - build and push bundle using GH actions on new tag Signed-off-by: Alexander Maslennikov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM