Increase Time Limit Scale Factors in Scenario Templates #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the `timeLimitScaleFactor` from 1 to 2 across multiple scenario templates. This change ensures extended time limits are applied, improving gameplay balance.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5209 +/- ##
=========================================
Coverage 10.52% 10.52%
- Complexity 6047 6051 +4
=========================================
Files 957 957
Lines 134523 134523
Branches 19545 19545
=========================================
+ Hits 14154 14158 +4
+ Misses 119018 119014 -4
Partials 1351 1351 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Changed `timeLimitAtMost` to false and updated `timeLimitType` to `ScaledToPrimaryUnitCount` to enhance the flexibility of time limits. Added `timeLimitScaleFactor` set to 2 to ensure the time limit scales appropriately with the number of primary units.
HammerGS
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the
timeLimitScaleFactorfrom 1 to 2 across multiple scenario templates. This change extends scenario time limits.Closes #5202 && #5226