Fix preview command sometimes not executing on Windows #81
Conversation
|
Nice, thanks! I will check if this still works for me. Generally, I'd favor a solution where we don't have to additionally detect the |
|
I would also want to find a better solution than this. However, others have run into the same issue on the IPython repo and the vscode-python repo, so it does not seem to have an easy fix. This solution should work out of the box for new users. Adding a delay between writing the command and the newline requires users to tweak the delay value. |
Yeah, this solution is definitely better than adding a delay. I just hope there will be a solution that gets to the root of this problem by means of a fix in the IPython repo or somewhere else where something like this would be tackled. But for now, if this fixes your problem that's already great and luckily this is also a fix that might be easily revertible once a solution is found in the future. |
|
Sadly, I tried again with shell integration and this time it broke again... After some debugging I found that it thinks that there is a command running after sending the checkpoint_paste(). So, when sending the extra newline, it will first send a CTRL+C to stop the first command, deleting the checkpoint_paste() line. I haven't been able to break the sendText method, so let's stick to that for now. |
|
Great, thanks for addressing all the points. The code looks good to me now. I just want to test this out a bit on my machine and ensure it doesn't break anything for me (we definitely need unit and integration tests in the very near future🙈, see #47). I will probably only be able to report on Friday as I'm a bit busy beforehand. |
* Improve testing docstrings & add convenience methods * Add laggy patched preview test & test sample * Remove code of fix #81 * Increase grid size a bit * Also try to remove ESC+ENTER * Install patch in site-packages * Remove patch from test samples * Improve error handling for when patch fails * Only apply fix on Windows * Fix wrong filename in test * Make scene laggier * Also escape \r in python string * Decrease grid size and increase timeout for tests * Simplify retrieval of python binary in environment * Add docstring for windows patch * Add docstring to function that executes patch and waits for success * Use success string that is not in source code itself * Use `python` instead of `python3` * Use Node.js `exec` instead of spawning new VSCode terminal See this comment: #117 (comment) * Remove prints in Python patch * Test that windows paste patch is correctly applied * Fix logger import path * Run all tests 🙈 (remove `it.only()` call) * Restore accidentally deleted lines * Assert that Logger.error() not called & use sinon.match * Add a manual delay in test * Stub Logger.info() and Logger.trace() to log outputs * Don't stub/spy twice & only test windows patch * Fix non-working windows paste patch test * Rename function to `applyWindowsPastePatch` * Increase timeout for windows paste patch test * Try to use python3 instead of python * Also inject Node.js exec() method for tests * Remove Emoji in Python patch to avoid encoding issues * Detect python in venv correctly on Windows & use `.exe` * Also call `python.exe` instead of just `python` in tests * Fix typo in windows paste patch * Log output of `exec()` in pipeline * Log separate groups of exec output * Print patch command to console * Get rid of \r in patch file for exec() * Also escape backslashes * Base64-encode/decode to get rid of nasty escape errors * Get rid of console logs & run all tests * Use color in Mocha TTY * Do some final cleanup
This PR attempts to fix the preview command on Windows. As seen in this video, sometimes checkpoint_paste() is not executed in the IPython shell, but it triggers the multiline input in IPython. In this PR, I detect the multiline input ("...:") and send "\x7F" to clear the extra line and send another newline to actually execute the command. This seems to fix the issue on my side. Let me know if you have any issues on other platforms!
Fixes #18