Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append ESC + ENTER at end of commands sent to IPython shell #110

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Splines
Copy link
Member

@Splines Splines commented Jan 10, 2025

During testing in #109, we noticed that #18 is still not working on Windows machines, even with #81. I try to address the issue here again, with a solution inspired by this SO answer. I.e. we append ESC + ENTER to any command sent to an IPython shell, see the line:

// append ESC + ENTER to avoid IPython starting a multi-line input (#18)
command += "\x1b\x0d";

This seems to work in CI/CD based on this run on #109 that already has the changes of this PR merged.


For reviewers on Windows machines @RickLuiken:

  • please test that you can use the extension as usual, e.g. to preview cells.
  • if this fix works: does it still work if you comment out these lines?

@Splines
Copy link
Member Author

Splines commented Jan 10, 2025

Note that the tests in this PR are not significant since we only introduce some relevant tests in #109.

@Splines
Copy link
Member Author

Splines commented Jan 10, 2025

Merging this to move on. However, I'm still particularly interested to know if this fix works for you even if you comment out these lines?

@Splines Splines merged commit cc960c7 into main Jan 10, 2025
4 checks passed
@Splines Splines deleted the fix/ipython-newline branch January 10, 2025 09:52
@RickLuiken
Copy link
Contributor

Hi @Splines, I tested this with the latest commit and the latest manim version, it seems to still work! However, I tried also with commenting the lines you mentioned, and the fix did not work on this LaggyScene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants