Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control-administrative): delay form mutation for 5 sec #304

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

xtiannyeto
Copy link
Collaborator

  • use FormikEffect and Formik component
  • Add timer to delay mutation
  • Test eveything

@xtiannyeto xtiannyeto linked an issue Aug 22, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 22, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 77.73% (🎯 50%) 1795 / 2309
🟢 Statements 77.64% (🎯 50%) 1862 / 2398
🟢 Functions 75% (🎯 50%) 462 / 616
🟢 Branches 68.67% (🎯 50%) 765 / 1114
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/features/pam/mission/components/elements/controls/control-administrative-form.tsx 90.9% 80% 100% 100% 65, 81
frontend/src/features/pam/mission/components/elements/controls/control-gens-de-mer-form.tsx 90.9% 80% 100% 100% 60, 76
frontend/src/features/pam/mission/components/elements/controls/control-navigation-form.tsx 90% 80% 100% 100% 41, 53
frontend/src/features/pam/mission/components/elements/controls/control-security-form.tsx 90% 80% 100% 100% 41, 53
frontend/src/features/pam/mission/components/ui/control-title-checkbox.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/hooks/control/use-control.tsx 92.85% 83.33% 100% 100% 37, 46
Generated in workflow #950

@xtiannyeto xtiannyeto force-pushed the feature/298-offline-batch-requetes-dun-meme-form branch from 7adda59 to 45cee9c Compare August 27, 2024 15:03
 - use FormikEffect and Formik component
 - Add timer to delay mutation
 - Test eveything
 - new arborescence and fix test
 - Create hook with common behavior of control
 - Test hook
 - Refactor control administrative to use hook
 - Refactor control gens de mer to use hook
 - Test control gens de mer
  -  block init calls
 - Just test Have been called.
 - TODO: check number of called for later
 - default behavior, if data and unitHasConfirm null then set true
 - move common check into hook
 - test it
 - on security and navigation control use hook useControl
 - on security and navigation control Refactor form with formik and FormikEffect
 - On administrative and gensDeMer, remove control already in useControl hook
 - Add tests
 - Remove _ import, just methods
@xtiannyeto xtiannyeto force-pushed the feature/298-offline-batch-requetes-dun-meme-form branch from b5d980b to 6dd1db1 Compare September 4, 2024 13:41
@xtiannyeto xtiannyeto self-assigned this Sep 9, 2024
@xtiannyeto xtiannyeto merged commit 33e1c8f into main Sep 12, 2024
9 checks passed
@xtiannyeto xtiannyeto deleted the feature/298-offline-batch-requetes-dun-meme-form branch September 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants