-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(control): refactor security and navigation
- on security and navigation control use hook useControl - on security and navigation control Refactor form with formik and FormikEffect - On administrative and gensDeMer, remove control already in useControl hook - Add tests
- Loading branch information
1 parent
e36d577
commit b5d980b
Showing
6 changed files
with
333 additions
and
163 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
...nd/src/features/pam/mission/components/elements/controls/control-navigation-form.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import { ControlAdministrative, ControlGensDeMer, ControlNavigation } from '@common/types/control-types' | ||
| import { Params } from 'react-router-dom' | ||
| import { vi } from 'vitest' | ||
| import { fireEvent, render, screen } from '../../../../../../test-utils' | ||
| import * as useControlHook from '../../../hooks/control/use-control' | ||
| import ControlNavigationForm from './control-navigation-form' | ||
|
|
||
| const updateControlMock = vi.fn() | ||
| const toogleControlMock = vi.fn() | ||
| const controlChangedMock = vi.fn() | ||
|
|
||
| vi.mock('react-router-dom', async importOriginal => { | ||
| const actual = await importOriginal() | ||
| return { | ||
| ...actual, | ||
| useParams: (): Readonly<Params<string>> => ({ missionId: '761', actionId: '3434' }) | ||
| } | ||
| }) | ||
|
|
||
| describe('ControlNavigationForm', () => { | ||
| afterEach(() => { | ||
| vi.clearAllMocks() | ||
| vi.resetAllMocks() | ||
| }) | ||
|
|
||
| it('should render control navigation form', () => { | ||
| const data = { | ||
| id: '', | ||
| amountOfControls: 0 | ||
| } as ControlGensDeMer | ||
| render(<ControlNavigationForm data={data} />) | ||
| expect(screen.getByText('Respect des règles de navigation')).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('it should have control navigation title check when should complete control is true', () => { | ||
| const data = { | ||
| id: '', | ||
| amountOfControls: 0 | ||
| } as ControlGensDeMer | ||
| const wrapper = render(<ControlNavigationForm data={data} shouldCompleteControl={false} />) | ||
| const checkbox = wrapper.container.querySelectorAll("input[type='checkbox']")[0] as HTMLInputElement | ||
| expect(checkbox).toBeChecked() | ||
| }) | ||
|
|
||
| it('it should display required red ', () => { | ||
| const wrapper = render(<ControlNavigationForm shouldCompleteControl={true} />) | ||
| expect(wrapper.getAllByTestId('control-title-required-control')).not.toBeNull() | ||
| }) | ||
|
|
||
| it('it should show unit should confirm toogle', () => { | ||
| const data = { | ||
| id: '', | ||
| amountOfControls: 0 | ||
| } as ControlAdministrative | ||
| render(<ControlNavigationForm data={data} unitShouldConfirm={true} />) | ||
| expect(screen.getByText('Contrôle confirmé par l’unité')).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('it should trigger delete control', async () => { | ||
| const useControlSpy = vi.spyOn(useControlHook, 'useControl') | ||
| useControlSpy.mockReturnValue({ | ||
| isRequired: false, | ||
| controlIsChecked: false, | ||
| updateControl: updateControlMock, | ||
| toggleControl: toogleControlMock, | ||
| controlChanged: controlChangedMock | ||
| }) | ||
| const data = { | ||
| id: 'scscss', | ||
| observations: 'myObservations' | ||
| } as ControlNavigation | ||
|
|
||
| const wrapper = render(<ControlNavigationForm data={data} shouldCompleteControl={true} unitShouldConfirm={false} />) | ||
| const checkbox = wrapper.container.querySelectorAll("input[type='checkbox']")[0] as HTMLInputElement | ||
| fireEvent.click(checkbox) | ||
| expect(toogleControlMock).toHaveBeenCalledTimes(1) | ||
| }) | ||
|
|
||
| it('it should update form and trigger use control controlChanged', async () => { | ||
| const useControlSpy = vi.spyOn(useControlHook, 'useControl') | ||
| useControlSpy.mockReturnValue({ | ||
| isRequired: true, | ||
| controlIsChecked: false, | ||
| updateControl: updateControlMock, | ||
| toggleControl: toogleControlMock, | ||
| controlChanged: controlChangedMock | ||
| }) | ||
| render(<ControlNavigationForm shouldCompleteControl={false} unitShouldConfirm={false} />) | ||
| const observations = screen.getByLabelText('Observations (hors infraction) sur les règles de navigation') | ||
| fireEvent.change(observations, { target: { value: 'my observations' } }) | ||
| expect(controlChangedMock).toHaveBeenCalled() //TODO: check number of times | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.