Update #8
Merged
Update #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tinatorabi
commented
Jun 17, 2024
tinatorabi
commented
- fixed issue regarding htpynewlam
- I'm now using Julia logging @info and so on
- using latex in the inline docs now
- added Orthogonal Matching Pursuit(OMP)
- added Basis Pursuit Denoising(BPDN)
cortner
approved these changes
Jun 17, 2024
…Pursuit.jl into tt "Merge completed"
cortner
requested changes
Jun 19, 2024
|
Then this should be ready to merge and register? |
|
maybe not quite. The readme still needs at least an example. |
|
@cortner I just updated readme. :) |
cortner
reviewed
Jun 19, 2024
cortner
reviewed
Jun 19, 2024
README.md
Outdated
| ``` | ||
| After completing the optimization process, the solution and the regularization parameter at each iteration `itn` can be accessed as follows: | ||
| ```jlcon | ||
| julia> xx, λ = tracer[itn] |
There was a problem hiding this comment.
drop the julia> and add another comment how to extract the final iterate using tracer[end]
mpf
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Just a few comments small requested changes.
Thanks, @tinatorabi !
| * `b` : `m`-vector. | ||
| * `λin` : Nonnegative scalar. | ||
| * `bl`, `bu` : `n`-vectors (bl lower bound, bu upper bound). | ||
| * `active`, `state`, `y`, `S`, `R` : May be empty or output from `BPdual` with a previous value of `λ`. |
There was a problem hiding this comment.
sorry I'm not quite sure what you mean by this :)
|
Fixes #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.