Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note support to (party) block opponents #3348

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Add note support to (party) block opponents #3348

merged 3 commits into from
Oct 5, 2023

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 3, 2023 •
edited
Loading

Summary

Add note support to (party) block opponents
And add missing anno for dq in BlockOpponentProps

How did you test this change?

dev
Screenshot 2023-10-04 082156

@hjpalpha hjpalpha requested review from mbergen and iMarbot October 3, 2023 05:52
@hjpalpha hjpalpha mentioned this pull request Oct 3, 2023
Merged
1 task
iMarbot
iMarbot approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@iMarbot iMarbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, however, I don't actually know what this changes/adds exactly since no screenshots/links.

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Oct 3, 2023 •
edited
Loading

Code LGTM, however, I don't actually know what this changes/adds exactly since no screenshots/links.

adds whatever text is provided as "note" as super script on the first player in a party opponent

basically it is just copied from downstream where it is used already
usecase is for example participant tables on sc/sc2/... where one should be able to add a number that way to indicate there is a note below it

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Oct 3, 2023 •
edited
Loading

will readjust it a bit (the note floats right for some reason)

@hjpalpha hjpalpha marked this pull request as draft October 3, 2023 18:23
@hjpalpha hjpalpha marked this pull request as ready for review October 4, 2023 05:55
@hjpalpha hjpalpha requested a review from iMarbot October 4, 2023 05:55
@hjpalpha hjpalpha requested a review from Rathoz October 4, 2023 09:10
@Rathoz Rathoz merged commit cc82fb6 into main Oct 5, 2023
2 checks passed
@Rathoz Rathoz deleted the add-note-support-to-block-opponent branch October 5, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbergen mbergen mbergen approved these changes

@iMarbot iMarbot iMarbot approved these changes

@Rathoz Rathoz Awaiting requested review from Rathoz

Assignees
No one assigned
Labels
c: opponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hjpalpha @iMarbot @mbergen @Rathoz