Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create participant table Component #3346

Merged
merged 32 commits into from
Oct 13, 2023
Merged

Create participant table Component #3346

merged 32 commits into from
Oct 13, 2023

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 2, 2023 •
edited
Loading

Summary

Create ParticipantsTable Component

  • should be able to replace several wiki modules and 3 commons modules (which use downstream stuff)
  • import functionality via matchGroupSpecs (similar to Prize pool)
  • sync player info
  • set Variables for players
  • supports literal and party opponents
  • stores data (similar to TeamCard)

How did you test this change?

"live" since new modules
https://liquipedia.net/starcraft2/User:Hjpalpha/wip34
Screenshot 2023-10-04 082334
Screenshot 2023-10-04 082226

to do

  • kick /dev on json when the according pr is merged

@hjpalpha hjpalpha marked this pull request as draft October 2, 2023 15:54
@hjpalpha hjpalpha changed the title [WIP] Add participant table module [WIP] Create participant table cponent Oct 3, 2023
@hjpalpha hjpalpha changed the title [WIP] Create participant table cponent Create participant table cponent Oct 4, 2023
@hjpalpha hjpalpha changed the title Create participant table cponent Create participant table Component Oct 4, 2023
@hjpalpha hjpalpha marked this pull request as ready for review October 5, 2023 14:23
@hjpalpha hjpalpha requested review from iMarbot and mbergen October 5, 2023 14:23
@hjpalpha hjpalpha requested a review from iMarbot October 5, 2023 18:33
iMarbot
iMarbot approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@iMarbot iMarbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the still open LPDB data comment, LGTM.

@hjpalpha hjpalpha requested a review from Rathoz October 6, 2023 09:56
Rathoz
Rathoz approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rathoz Rathoz merged commit c45d6ee into main Oct 13, 2023
2 checks passed
@Rathoz Rathoz deleted the participantTable branch October 13, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMarbot iMarbot iMarbot approved these changes

@Rathoz Rathoz Rathoz approved these changes

@mbergen mbergen Awaiting requested review from mbergen

Assignees
No one assigned
Labels
c: participant_table
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjpalpha @Rathoz @iMarbot