Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MatchSummary Modules #3300

Closed
wants to merge 2 commits into from
Closed

Rework MatchSummary Modules #3300

wants to merge 2 commits into from

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Sep 20, 2023

base for merging the parts of the rework into for easier review on the parts

need to merge all of them together into main due to breaking changes

Summary

Rework MatchSummary modules

  • add some more default handling via commons
  • rework reset display

How did you test this change?

dev

To-Do

@hjpalpha hjpalpha changed the title Add Retired display in heroes infobox person (#3296) Rework MatchSummary Modules Sep 20, 2023
@hjpalpha
Copy link
Collaborator Author

rath suggested a better way

@hjpalpha hjpalpha closed this Sep 22, 2023
@hjpalpha hjpalpha deleted the matchsummary-rework branch September 22, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant