Update Fighters info.lua #3303
Closed
Update Fighters info.lua #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgc will need customized opponent display due to character use in match2 components. localized from commons for now. adjustments to be made before fighters gets their github thingy.
hjpalpha
requested changes
Sep 20, 2023
There was a problem hiding this comment.
- add the customs to the git before adjusting module info (you can use info/dev if you need them for testing) or do it in the same PR
- from looking at opponent/Custom you set up on fighters wiki on phone it seems redundant (commons already does that)
- OpponentDisplay/Custom currently looks like a copy of commons, so it would need some adjusting for sure.
- keep in mind opponentDisplay is not only used in brackets but also in lots of other places, including prize pools, results tables, ...
- please note we are currently reworking how matchsummary modules work a bit, see Rework MatchSummary Modules #3300 and Rework MatchSummary - Commons and brawlstars #3295
|
I'm not gonna rewrite the whole match2 structure only to add inline characters |
who said something about rewriting whole match2 structure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fgc will need customized opponent display due to character use in match2 components.
localized from commons for now. adjustments to be made before fighters gets their github thingy.