Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchSummary for Tetris #2480

Merged
merged 9 commits into from
Oct 13, 2023
Merged

MatchSummary for Tetris #2480

merged 9 commits into from
Oct 13, 2023

Conversation

Hesketh2
Copy link
Collaborator

@Hesketh2 Hesketh2 commented Jan 30, 2023

Summary

Part of Match2 Implementation

PRs starts with non-team stuff. When merged, a 2nd PR which contain team stuff is then up
(This also applies to MatchGroup)

How did you test this change?

For Part 1 (non-team stuff) = LIVE
(e.g. https://liquipedia.net/tetris/CTWC/2022)

Hesketh2 and others added 6 commits January 30, 2023 20:28
- Fix Abbreviation and Libraries unused variables
- I dont know how to tackle LINK_DATA, this  will come solved in 2nd update
@hjpalpha hjpalpha removed their request for review September 28, 2023 14:13
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rathoz Rathoz merged commit e43f7d6 into main Oct 13, 2023
2 checks passed
@Rathoz Rathoz deleted the H2-Match2-Summary branch October 13, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants