Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MatchSummary for Clash Royale #2254

Merged
merged 22 commits into from
Oct 16, 2023
Merged

Add MatchSummary for Clash Royale #2254

merged 22 commits into from
Oct 16, 2023

Conversation

Hesketh2
Copy link
Collaborator

@Hesketh2 Hesketh2 commented Dec 23, 2022

Summary

Part of Match2 Implementation, largely based from Starcraft with large changes due to CR's niche game structure.

The game involves usage of both 1v1, 2v2 and Teams events
Alongside "Sets" (where a team match consists an array of 1v1 and 2v2 sets/subgroups) and the need of Card inputs (which is same manner as Characters in MOBA match2s)

for team matches the display is very basic and does not display much information appart from the submatch total scores

BIG MATCH SCRAPPED, We'll go with what currently looks like now

How did you test this change?

/Dev and Live environment usage (update)

@hjpalpha hjpalpha removed their request for review December 23, 2022 10:15
@hjpalpha
Copy link
Collaborator

hjpalpha commented Dec 23, 2022

thinking that due the amount of data they want to display in team matches it might be good to use BigMatch for team matches on the CR wiki

MS would then just show a very brief summary of the submatches and their scores without any card (pick/ban)

something like:
image
plus a link to big match of course
and also mention for the koth that it is koth (below the score maybe)

Hesketh2 and others added 5 commits December 27, 2022 14:50
add matchSummary display for team matches
- assumes bigmatch will get implemented on the wiki
- big match is supposed to hold card data and more info on the koth submatches
- match summary only displays a very densed down info about the match due to else having way too much data in the small match summary popups
@hjpalpha
Copy link
Collaborator

imo ready

@Hesketh2 Hesketh2 marked this pull request as ready for review December 27, 2022 13:32
@Rathoz Rathoz marked this pull request as draft December 30, 2022 12:46
@Rathoz Rathoz marked this pull request as ready for review December 30, 2022 12:46
@Rathoz
Copy link
Collaborator

Rathoz commented Dec 30, 2022

Opening post needs updating

@Rathoz
Copy link
Collaborator

Rathoz commented Dec 30, 2022

thinking that due the amount of data they want to display in team matches it might be good to use BigMatch for team matches on the CR wiki

MS would then just show a very brief summary of the submatches and their scores without any card (pick/ban)

something like: image plus a link to big match of course and also mention for the koth that it is koth (below the score maybe)

Big Match is unlikely for any wiki where we don't have an API to get the data.

@hjpalpha
Copy link
Collaborator

hjpalpha commented Dec 30, 2022

thinking that due the amount of data they want to display in team matches it might be good to use BigMatch for team matches on the CR wiki
MS would then just show a very brief summary of the submatches and their scores without any card (pick/ban)
something like: image plus a link to big match of course and also mention for the koth that it is koth (below the score maybe)

Big Match is unlikely for any wiki where we don't have an API to get the data.

the idea is to have the card information for team matches only there and not inside matchsummary
additionally i do not see a way to display the king of the hill structure in matchsummary in a way that doesn't mean a very very long matchsummary

so the idea for big match is more so that there is a way to display the information which take up much space
it is not to add stats data or such

like it would be

  • card information (8 per player) per map/game
  • map/game winner display (in MS only the accumulated scores of the submatch)
  • in case of a koth display which player played which map/game
  • card bans (1 per player per map/game)

for non team matches we already display cards (8 per player) and bans so the the big difference is only due to the structure of team matches (with submatches)

tldr the display is big but the entered data is not so much

- kick warning that bigMatch is not yet implemented
- lock link to bigMatch behind switch
@hjpalpha hjpalpha marked this pull request as draft January 1, 2023 18:33
@hjpalpha hjpalpha marked this pull request as ready for review January 3, 2023 11:42
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at teams

components/match2/wikis/clashroyale/match_summary.lua Outdated Show resolved Hide resolved
components/match2/wikis/clashroyale/match_summary.lua Outdated Show resolved Hide resolved
components/match2/wikis/clashroyale/match_summary.lua Outdated Show resolved Hide resolved
components/match2/wikis/clashroyale/match_summary.lua Outdated Show resolved Hide resolved
@hjpalpha hjpalpha marked this pull request as draft January 10, 2023 18:40
@Hesketh2 Hesketh2 marked this pull request as ready for review September 28, 2023 11:27
@Rathoz Rathoz merged commit 84a825c into main Oct 16, 2023
@Rathoz Rathoz deleted the H2-CRMatch2-Summary branch October 16, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants