-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MatchSummary
for Clash Royale
#2254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add matchSummary display for team matches - assumes bigmatch will get implemented on the wiki - big match is supposed to hold card data and more info on the koth submatches - match summary only displays a very densed down info about the match due to else having way too much data in the small match summary popups
imo ready |
Opening post needs updating |
- kick warning that bigMatch is not yet implemented - lock link to bigMatch behind switch
Rathoz
reviewed
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at teams
Co-authored-by: Rikard Blixt <[email protected]>
Co-authored-by: Rikard Blixt <[email protected]>
This was referenced Sep 20, 2023
Rathoz
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of Match2 Implementation, largely based from Starcraft with large changes due to CR's niche game structure.
The game involves usage of both 1v1, 2v2 and Teams events
Alongside "Sets" (where a team match consists an array of 1v1 and 2v2 sets/subgroups) and the need of Card inputs (which is same manner as Characters in MOBA match2s)
for team matches the display is very basic and does not display much information appart from the submatch total scores
BIG MATCH SCRAPPED, We'll go with what currently looks like now
How did you test this change?
/Dev and Live environment usage (update)