Save manually input player team to page var if syncPlayer is enabled (

#3383) * Save manually input player team to page var if `syncPlayer` is enabled * starcraft * break line * break line * warcraft
Liquipedia · Oct 16, 2023 · b141997 · b141997
1 parent 27da3a8
commit b141997
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/components/opponent/commons/opponent.lua b/components/opponent/commons/opponent.lua
@@ -304,10 +304,10 @@ function Opponent.resolve(opponent, date, options)
 	elseif Opponent.typeIsParty(opponent.type) then
 		for _, player in ipairs(opponent.players) do
 			if options.syncPlayer then
-				PlayerExt.syncPlayer(player, {savePageVar = not Opponent.playerIsTbd(player)})
-				if not player.team then
-					player.team = PlayerExt.syncTeam(player.pageName:gsub(' ', '_'), nil, {date = date})
-				end
+				local savePageVar = not Opponent.playerIsTbd(player)
+				PlayerExt.syncPlayer(player, {savePageVar = savePageVar})
+				player.team =
+					PlayerExt.syncTeam(player.pageName:gsub(' ', '_'), player.team, {date = date, savePageVar = savePageVar})
 			else
 				PlayerExt.populatePageName(player)
 			end

diff --git a/components/opponent/commons/starcraft_starcraft2/opponent_starcraft.lua b/components/opponent/commons/starcraft_starcraft2/opponent_starcraft.lua
@@ -160,10 +160,10 @@ function StarcraftOpponent.resolve(opponent, date, options)
 		for _, player in ipairs(opponent.players) do
 			if options.syncPlayer then
 				local hasRace = String.isNotEmpty(player.race)
-				StarcraftPlayerExt.syncPlayer(player, {savePageVar = not Opponent.playerIsTbd(player --[[@as standardPlayer]])})
-				if not player.team then
-					player.team = PlayerExt.syncTeam(player.pageName:gsub(' ', '_'), nil, {date = date})
-				end
+				local savePageVar = not Opponent.playerIsTbd(player --[[@as standardPlayer]])
+				StarcraftPlayerExt.syncPlayer(player, {savePageVar = savePageVar})
+				player.team =
+					PlayerExt.syncTeam(player.pageName:gsub(' ', '_'), player.team, {date = date, savePageVar = savePageVar})
 				player.race = (hasRace or player.race ~= Faction.defaultFaction) and player.race or nil
 			else
 				PlayerExt.populatePageName(player)

diff --git a/components/opponent/wikis/warcraft/opponent_custom.lua b/components/opponent/wikis/warcraft/opponent_custom.lua
@@ -126,10 +126,10 @@ function CustomOpponent.resolve(opponent, date, options)
 		for _, player in ipairs(opponent.players) do
 			if options.syncPlayer then
 				local hasRace = String.isNotEmpty(player.race)
-				PlayerExt.syncPlayer(player, {savePageVar = not Opponent.playerIsTbd(player)})
-				if not player.team then
-					player.team = PlayerExt.syncTeam(player.pageName, nil, {date = date})
-				end
+				local savePageVar = not Opponent.playerIsTbd(player)
+				PlayerExt.syncPlayer(player, {savePageVar = savePageVar})
+				player.team =
+					PlayerExt.syncTeam(player.pageName:gsub(' ', '_'), player.team, {date = date, savePageVar = savePageVar})
 				player.race = (hasRace or player.race ~= Faction.defaultFaction) and player.race or nil
 			else
 				PlayerExt.populatePageName(player)