Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use std::optional<std::string> over std::string* #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use std::optional<std::string> over std::string* #20

wants to merge 1 commit into from

Conversation

ronag
Copy link
Contributor

@ronag ronag commented Apr 3, 2022

No description provided.

ronag
ronag commented Apr 3, 2022
View reviewed changes
binding.cc Outdated Show resolved Hide resolved
@ronag ronag force-pushed the optional branch 2 times, most recently from 45995a3 to f59bffd Compare April 3, 2022 11:40
@ronag ronag mentioned this pull request Apr 3, 2022
Closed
This was referenced Apr 9, 2022
Closed
Closed
@ronag ronag force-pushed the optional branch 2 times, most recently from 6aecd45 to ddb6cf4 Compare April 9, 2022 11:10
@ronag
Copy link
Contributor Author

ronag commented Apr 19, 2022

@vweevers this won't work as prebuildify-cross will fail for std::optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Level
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ronag