Reduce heap allocations and use modern cpp #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
bindings
branch
4 times, most recently
from
51ab608 to
e54d344
Compare
|
It'd be good to separate pure cosmetic changes (that can potentially be merged quickly) from ones that benefit performance, because the latter require benchmarks. |
|
Do you have any benchmarking script? |
|
Yes, but it comes with instructions - that I'll write later |
|
TBH I don't really see anything here that in theory could cause perf regression. |
|
I think it looks good but there are a lot of changes for a single commit. |
ronag
commented
Apr 3, 2022
| @@ -8,7 +8,7 @@ jobs: | |||
| matrix: | |||
| # At the time of writing macos-latest is mac 10; we need 11 to build a universal binary. | |||
| os: [ubuntu-latest, macos-11, windows-latest] | |||
| node: [12, 14, 16] | |||
| node: [14, 16] | |||
There was a problem hiding this comment.
For some reason doesn't build on v12? Old cpp version?
|
I'l lsplit this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.