Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse fonts #418

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Parse fonts #418

merged 4 commits into from
Sep 4, 2023

Conversation

dmorais-ledger
Copy link
Contributor

Remove OCR for LNX, LNS+ & Stax devices

  • Parse ELF data to find fonts information on LNX & LNS+ (for Stax, fonts are loaded at a known location).
  • Use those information to build a bitmap -> character array
  • No need to change Bolos nor the SDK!
  • All active API levels are supported (1, 5 & 12)

NB: legacy OCR is kept for SDK prior to unification.

xchapron-ledger
xchapron-ledger approved these changes Sep 1, 2023
View reviewed changes
speculos/main.py Outdated Show resolved Hide resolved
src/bolos/nbgl.c Outdated Show resolved Hide resolved
xchapron-ledger
xchapron-ledger reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CI issues to fix too, else looks promising!

lpascal-ledger
lpascal-ledger reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • some misspells pointed by the CI.

Nice to see such code simplification.

speculos/mcu/nbgl.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
@xchapron-ledger xchapron-ledger mentioned this pull request Sep 4, 2023
Closed
@dmorais-ledger dmorais-ledger merged commit d6dee99 into master Sep 4, 2023
18 checks passed
@dmorais-ledger dmorais-ledger deleted the parse_fonts branch September 4, 2023 07:10
@emturner emturner mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpascal-ledger lpascal-ledger lpascal-ledger left review comments

@xchapron-ledger xchapron-ledger xchapron-ledger approved these changes

@agrojean-ledger agrojean-ledger Awaiting requested review from agrojean-ledger

@yhql yhql Awaiting requested review from yhql

@abonnaudet-ledger abonnaudet-ledger Awaiting requested review from abonnaudet-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmorais-ledger @lpascal-ledger @xchapron-ledger